Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: change text in courtesy notification #1266

Merged

Conversation

benerken
Copy link
Contributor

@benerken benerken commented Oct 7, 2020

Co-Authored-by: Benoit Erken [email protected]

Why are you opening this PR?

  • Remove hardcoded field "Note" in due_soon templates.

Dependencies

How to test?

  • Do a checkout, wait to receive the courtesy notice and check there is no "Note" field in the body.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

* Remove hardcoded field "Note" in due_soon templates.
* Closes rero#1264.

Co-Authored-by: Benoit Erken <[email protected]>
@AoNoOokami AoNoOokami self-requested a review October 7, 2020 14:18
@benerken benerken merged commit 290dfd6 into rero:dev Oct 8, 2020
@benerken benerken deleted the ber-fix-change-text-in-courtesy-notification branch November 30, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

circulation: change text in courtesy notification
5 participants