Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update to ES7 and invenio 3.3 #1175

Merged
merged 1 commit into from
Sep 24, 2020
Merged

dependencies: update to ES7 and invenio 3.3 #1175

merged 1 commit into from
Sep 24, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Aug 23, 2020

  • Updates ES version to 7.9.0.
  • Updates invenio to version to 3.3.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

-We need ES 7 to implement ES cluster in kubernets

Dependencies

How to test?

  • run scripts bootstrap and setup (maybe the virtual python env and static folder must be deleted)
  • see everything works as expected

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep added the dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed label Aug 23, 2020
@rerowep rerowep self-assigned this Aug 23, 2020
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch 3 times, most recently from 1229e40 to 96d5e7e Compare August 23, 2020 20:26
iGormilhit
iGormilhit suggested changes Aug 24, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message changes:

  • * Updates ES version to 7.9.0. → * Updates ES to 7.9.0.
  • * Updates invenio to version to 3.3. → * Updates invenio to 3.3.

@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch 5 times, most recently from ea16567 to 26b1fd4 Compare August 26, 2020 06:15
@iGormilhit iGormilhit added this to the v0.13.0 milestone Aug 27, 2020
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from 26b1fd4 to 8f973a4 Compare August 31, 2020 15:13
iGormilhit
iGormilhit suggested changes Sep 1, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message: Updates invenio to to 3.3. → Updates invenio to 3.3.

@jma jma marked this pull request as draft September 1, 2020 11:54
@jma jma removed their request for review September 1, 2020 11:54
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from 8f973a4 to 9ff80f4 Compare September 3, 2020 11:51
@rerowep rerowep requested a review from iGormilhit September 3, 2020 12:05
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch 3 times, most recently from 7685be4 to b9aa2ff Compare September 4, 2020 08:35
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch 8 times, most recently from f69b014 to 19a9e25 Compare September 6, 2020 14:06
iGormilhit
iGormilhit approved these changes Sep 7, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from 19a9e25 to d6b32dc Compare September 7, 2020 21:05
@iGormilhit iGormilhit self-requested a review September 8, 2020 04:27
iGormilhit
iGormilhit reviewed Sep 8, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention changes on the travis file in the commit message, if relevant.

@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch 3 times, most recently from 2e353b8 to b081cbb Compare September 15, 2020 09:40
@iGormilhit iGormilhit linked an issue Sep 16, 2020 that may be closed by this pull request
elasticsearch document_type deprecated #83
Closed
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from b081cbb to dcbd28f Compare September 16, 2020 05:53
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from dcbd28f to 815647e Compare September 23, 2020 10:16
@rerowep rerowep marked this pull request as ready for review September 23, 2020 11:16
@rerowep
dependencies: update to ES7 and invenio 3.3
71dda52 
* Updates ES to 7.9.0.
* Updates invenio to to 3.3.
* closes rero#83

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-##1638-update-dependencies branch from 815647e to 71dda52 Compare September 23, 2020 11:57
@rerowep rerowep merged commit ad79574 into rero:dev Sep 24, 2020
@rerowep rerowep deleted the wep-##1638-update-dependencies branch September 24, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@jma jma Awaiting requested review from jma

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@rerowep rerowep

Labels
dev: dependencies Related to a dependency that needs to be fixed, or pinned, or changed
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

elasticsearch document_type deprecated
4 participants
@rerowep @Garfield-fr @iGormilhit @zannkukai