Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: test the creation of a simple document #1116

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Jul 27, 2020

  • Creates a test for the creation of a document with only essential
    fields.
  • Creates document fixture.
  • Corrects jsonschema (countries, provision activity).
  • Corrects checkout-checkin test to use custom ids in editor.

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To implement a test of the user interface of the documents editor. First case: create a document with essential fields only.
https://tree.taiga.io/project/rero21-reroils/task/1562?kanban-status=1224894

Dependencies

My PR depends on the following PR(s):

  • dev of rero-ils-ui
  • dev of ng-core

How to test?

You need a bootstrap and a setup, and run the server with FLASK_DEBUG=False poetry run server, otherwise the test will fail.
Check that FLASK_DEBUG=False is not overwritten in invenio.cfg.

To run the tests on command line: poetry run cypress (all the tests).
Or with a GUI: cd tests/e2e/cypress, then npm run cypress. Click on Run all specs on top right of the interface.
Try different browsers.

Documentation: https://github.com/rero/developer-resources/blob/master/base/cypress.md

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami self-assigned this Jul 27, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-#1562-cypress-test-editor-simple-document branch 6 times, most recently from 9f21378 to 4e695c9 Compare August 3, 2020 14:54
@AoNoOokami AoNoOokami force-pushed the zaa-#1562-cypress-test-editor-simple-document branch 5 times, most recently from e072e77 to 40e44c7 Compare August 5, 2020 14:08
@AoNoOokami AoNoOokami marked this pull request as ready for review August 5, 2020 14:29
@AoNoOokami AoNoOokami force-pushed the zaa-#1562-cypress-test-editor-simple-document branch 2 times, most recently from c5e9caa to 30d7fcd Compare August 7, 2020 07:02
* Creates a test for the creation of a document with only essential
fields.
* Creates document fixture.
* Corrects jsonschema (countries, provision activity).
* Corrects checkout-checkin test to use custom ids in editor.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-#1562-cypress-test-editor-simple-document branch from 30d7fcd to b550bd2 Compare August 7, 2020 08:05
@AoNoOokami AoNoOokami requested a review from zannkukai August 7, 2020 08:22
@AoNoOokami AoNoOokami merged commit 828ff75 into rero:dev Aug 7, 2020
@AoNoOokami AoNoOokami deleted the zaa-#1562-cypress-test-editor-simple-document branch August 21, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants