Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: fix edition with notes #1062

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Jun 22, 2020

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To allow the creation or edition of a document with notes.

Dependencies

My PR depends on the following rero-ils-ui"s PR(s):

How to test?

Try to edit a document with notes.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami marked this pull request as ready for review June 22, 2020 13:16
* Removes notes_text from mapping.
* Creates a filter to display notes in detailed view.
* Closes rero#1036.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-fix-document-with-note-edition branch from 26e129b to f35a608 Compare June 22, 2020 13:40
@AoNoOokami AoNoOokami requested review from jma and rerowep June 22, 2020 14:10
@AoNoOokami AoNoOokami added this to the v0.10.0 milestone Jun 22, 2020
@AoNoOokami AoNoOokami self-assigned this Jun 22, 2020
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@AoNoOokami AoNoOokami merged commit ad1bd63 into rero:dev Jun 23, 2020
@AoNoOokami AoNoOokami deleted the zaa-fix-document-with-note-edition branch July 21, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to save the document editor with field "notes"
4 participants