Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation resources: circulation actions, reroils_resources and loan state chart #1017

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

blankoworld
Copy link
Contributor

Why are you opening this PR?

  • To have an history about circulation actions documentation
  • To update reroils_resources chart using dot from graphviz package
  • To update Loan state chart using dot from graphviz package

How to test?

  • Read doc/README.md and check each file/directory
  • Check doc/circulation/README.md on Github to see if any SVG file is displayed with Loan state diagram
  • Use Makefile files:
cd doc
make clean && make
cd circulation
make clean && make

and check all generated *.png and *.svg files.

NOTE: in a next step I will create a little bit documentation about Graphviz to understand how it works in RERO and how to solve some problem in creating graphs.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@benerken benerken self-requested a review June 2, 2020 06:18
* Deletes old reroils_resources.[odg|pdf] files
* Adds new reroils_resources.svg file

Co-Authored-by: Olivier DOSSMANN <[email protected]>
* Deletes old Graffle and PDF files about Loan state diagram
* Adds new Loan state diagram using `dot` from **graphviz**

Co-Authored-by: Olivier DOSSMANN <[email protected]>
@blankoworld blankoworld force-pushed the doo-documentation-resources branch from eac7b08 to dcbee82 Compare June 2, 2020 12:59
* Adds explanations about circulation actions
* Adds scenarios using actions

Co-Authored-by: Olivier DOSSMANN <[email protected]>
@blankoworld blankoworld force-pushed the doo-documentation-resources branch from dcbee82 to 8e785cb Compare June 2, 2020 14:57
@blankoworld blankoworld merged commit 6062c25 into rero:dev Jun 2, 2020
@blankoworld blankoworld deleted the doo-documentation-resources branch July 1, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants