Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: integration of invenio-sip2 module #1005

Merged
merged 1 commit into from
Jun 29, 2020
Merged

install: integration of invenio-sip2 module #1005

merged 1 commit into from
Jun 29, 2020

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented May 25, 2020 •
edited
Loading

  • Adds optional invenio-sip2 module to poetry dependencies.
  • Adds option into bootstrap to install sip2 module.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

How to test?

  • execute poetry run bootstrap
  • check if the CLI doesn"t contains selfcheck command : poetry run invenio --help
  • install sip2 module with :
    poetry install --extras sip2
    or
    poetry run bootstrap --sip2
  • check if the CLI contains selfcheck command
  • execute poetry run invenio selfcheck start -h 127.0.0.1 -p 3004
    (this command start the SIP2 socket server)

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@lauren-d lauren-d added this to the v0.9.0 milestone May 25, 2020
@lauren-d lauren-d self-assigned this May 25, 2020
@lauren-d lauren-d marked this pull request as draft May 25, 2020 08:35
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch from 34913b0 to 7610ed4 Compare May 25, 2020 09:05
@lauren-d lauren-d marked this pull request as ready for review May 25, 2020 09:37
rerowep
rerowep reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to add an option to start the SIP server with the server script or an extra sipsever script?

@lauren-d
Copy link
Contributor Author

lauren-d commented May 25, 2020 •
edited
Loading

Do we have to add an option to start the SIP server with the server script or an extra sipsever script?

At this time, I think this is prematured to want start sip2server with script because it"s very basic implementation. I will add that later.
It"s possible to launch SIP2 server using the CLI :
invenio selfcheck start -h 127.0.0.1 -p 3004

@lauren-d lauren-d force-pushed the lau-implements-sip2 branch from 7610ed4 to ab0651c Compare May 25, 2020 17:09
@lauren-d lauren-d requested a review from rerowep May 25, 2020 18:59
jma
jma approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to make this module optional during the installation such as poetry install [pip2] or similar

@lauren-d lauren-d removed this from the v0.9.0 milestone May 27, 2020
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch 2 times, most recently from 99b8b7d to 614e583 Compare May 27, 2020 09:55
@lauren-d lauren-d requested a review from jma May 27, 2020 09:56
@lauren-d
Copy link
Contributor Author

It would be great to make this module optional during the installation such as poetry install [pip2] or similar

done using poetry install --extras "sip2"

@iGormilhit iGormilhit added this to the v0.10.0 milestone May 27, 2020
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch 2 times, most recently from 9689943 to 939bc45 Compare May 27, 2020 13:44
@lauren-d lauren-d requested a review from rerowep May 28, 2020 07:52
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch 2 times, most recently from d02b5a8 to dd8bb20 Compare June 5, 2020 11:26
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch 4 times, most recently from e18ab7e to a4f6e81 Compare June 24, 2020 06:07
@lauren-d
install: integration of invenio-sip2 module
3226039 
* Adds optional invenio-sip2 module to poetry dependencies.
* Adds option into bootstrap to install sip2 module.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-implements-sip2 branch from a4f6e81 to 3226039 Compare June 29, 2020 07:13
@lauren-d lauren-d merged commit 4623157 into rero:dev Jun 29, 2020
@lauren-d lauren-d deleted the lau-implements-sip2 branch August 19, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep rerowep approved these changes

@BadrAly BadrAly BadrAly approved these changes

@benerken benerken benerken approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@lauren-d lauren-d

Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lauren-d @jma @iGormilhit @benerken @BadrAly @rerowep