Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing existing restriction on available pickup location prevents to save the record #988

Closed
zannkukai opened this issue May 12, 2020 · 2 comments
Closed

Removing existing restriction on available pickup location prevents to save the record #988

zannkukai opened this issue May 12, 2020 · 2 comments
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface

Comments

@zannkukai
Copy link
Contributor

Describe the issue
When a location already defined some restrict pickup locations, If manager try to remove restrictions, the form cannot be saved.

To Reproduce

  1. I have a location with pick up restriction (more than 1 pickup locations allowed)
  2. I edit this location
  3. I disable the button "Restrict pickup to"
  4. I cannot save

Expected behavior
Save button should be active

Software version
rero-ils version 9fbc355
rero-ils-ui version cf1a8517
@zannkukai
Copy link
Contributor Author

zannkukai commented May 12, 2020 •
edited
Loading

The problem is due to "toggle wrapper" from ng-core.
When we toggle-off the restrict_pickup_to, the children are reset to "blank" value. If there are more than one locations, then the reset cause multiple "null" values and the value for "restrict_location_to" array must be unique.

Expected behavior :
When the restrict_pickup_to toggle switch is off, then the additional fields should be removed (keeping only the first location with null value)

@zannkukai zannkukai mentioned this issue May 12, 2020
Merged
6 tasks
@iGormilhit iGormilhit changed the title Locations : removing restrict pickup locations Removing existing restriction on available pickup location prevents to save the record May 13, 2020
@iGormilhit iGormilhit added f: professional ui Professional interface f: circulation Concerns the circulation interface or backend labels May 13, 2020
@AoNoOokami
Copy link
Contributor

AoNoOokami commented Sep 15, 2020 •
edited
Loading

I close this issue, as it has been fixed in v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @zannkukai @AoNoOokami