Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action realised in circulation must be in the past participle #890

Closed
pronguen opened this issue Apr 2, 2020 · 0 comments
Closed

Action realised in circulation must be in the past participle #890

pronguen opened this issue Apr 2, 2020 · 0 comments
Labels
f: circulation Concerns the circulation interface or backend translations Translations
Milestone
Issues sprint 30

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 2, 2020

Describe the issue
In the checkin and checkout form, the action realised is in the infinitive, and this suggests a button, but it is only an information.

To Reproduce

  1. Open a patron account, as a librarian
  2. Do a renewal
  3. Name of button is "Renew", action realised is "renew"

Expected behavior
All actions realised are display in the past participle, in the checkin and in the checkout form.

Software version
ils.test.rero.ch (version 0.6.1)
ilspilot (phase 1 of tests)

Screenshot
image
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend translations Translations labels Apr 21, 2020
@iGormilhit iGormilhit added this to the Issues sprint 30 milestone Apr 21, 2020
@zannkukai zannkukai mentioned this issue Apr 30, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2020
@zannkukai
circulation: past participle used when action done
100dbb3 
Actions realised on item into checkin/checkout component are now display
in the past participle. This commit also updates button according UX
chart and the border around an operated item if special actions should
be done (fees|transit)

* Closes rero/rero-ils#890

Co-authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2020
@zannkukai
circulation: past participle used when action done
a632b15 
Actions realised on item into checkin/checkout component are now display
in the past participle. This commit also updates button according UX
chart and the border around an operated item if special actions should
be done (fees|transit)

* Closes rero/rero-ils#890

Co-authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2020
@zannkukai
circulation: past participle used when action done
01c685d 
Actions realised on item into checkin/checkout component are now display
in the past participle. This commit also updates button according UX
chart and the border around an operated item if special actions should
be done (fees|transit)

* Closes rero/rero-ils#890

Co-authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: circulation Concerns the circulation interface or backend translations Translations
Projects
None yet
Milestone
Issues sprint 30
Development

No branches or pull requests
2 participants
@iGormilhit @pronguen