Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ebooks records be editable ? #89

Closed
NicolasLabat opened this issue Sep 14, 2018 · 3 comments
Closed

Should ebooks records be editable ? #89

NicolasLabat opened this issue Sep 14, 2018 · 3 comments
Labels
enhancement Improvement of an existing feature f: ebooks

Comments

@NicolasLabat
Copy link
Contributor

NicolasLabat commented Sep 14, 2018 •
edited
Loading

If the librarian catalogues an ebook, he can"t edit the record once it is created.
Must some ebooks records be editable and others not (harvested ebooks) ?
@pronguen
Copy link
Contributor

Yes, indeed. The records that cannot be edited should be determined according to their provenance (Ebook server) and not to their document type.

@pronguen pronguen added bug f: editor Concerns editor based on JSON schema AND custom editor f: ebooks and removed question labels Sep 17, 2018
@iGormilhit
Copy link

iGormilhit commented Sep 18, 2018 •
edited
Loading

@NicolasLabat @pronguen It"s not a bug. It"s a feature. So, it"s a wish to improve this feature, in the future, when some non-synched ebooks will, maybe, exist.

@rerowep rerowep added enhancement Improvement of an existing feature and removed bug labels Sep 27, 2018
@iGormilhit iGormilhit added catalog and removed f: editor Concerns editor based on JSON schema AND custom editor labels Mar 25, 2019
@pronguen
Copy link
Contributor

Improvement wanted:

  • All documents from e-book server should not be editable.
  • Ebook should be editable if they don"t come from e-book server.

jma added a commit to jma/rero-ils that referenced this issue Jul 11, 2019
@jma
UI: display Elasticsearch score informations
3262759 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves remove useless pid existance check in JSON serializer.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Jul 11, 2019
@jma @Garfield-fr
UI: display Elasticsearch score informations
f9a68af 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves remove useless pid existance check in JSON serializer.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@jma jma mentioned this issue Jul 11, 2019
Closed
jma added a commit to jma/rero-ils that referenced this issue Jul 11, 2019
@jma @Garfield-fr
UI: display Elasticsearch score informations
c35d7d9 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves remove useless pid existance check in JSON serializer.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Jul 11, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
bc78af3 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves remove useless pid existance check in JSON serializer.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 12, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
a2cdfb8 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves remove useless pid existance check in JSON serializer.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Jul 12, 2019
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 12, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
7a7543c 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 15, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
8e6d698 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 16, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
6987d5f 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jul 16, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
f5b0f93 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes rero#384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes rero#89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Jul 16, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
b05eb74 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes #384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes #89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
iGormilhit pushed a commit that referenced this issue Aug 7, 2019
@jma @Garfield-fr
search: Replace AND default operator by OR.
7ecedae 
* Adds a new display_score url parameters `display_score=1`.
* Restore OR default search operator, closes #384.
* Improves Elasticsearch mappings and JSONSchema for documents:
  * two JSONSchema: one minimal for havested records and one for
  internal record.
  * unique elasticsearch mapping
* Put cantook and internal records in the same Elasticsearch index.
* Improves search page layout.
* Improves serializers permissions, closes #89.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@jma jma closed this as completed in 32a419d Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: ebooks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iGormilhit @pronguen @NicolasLabat @rerowep