Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to the patron profile not adapted to the concerned instance in the notification message. #802

Closed
pronguen opened this issue Feb 25, 2020 · 1 comment · Fixed by #1029
Closed

Link to the patron profile not adapted to the concerned instance in the notification message. #802

pronguen opened this issue Feb 25, 2020 · 1 comment · Fixed by #1029
Assignees
@rerowep
Labels
f: notifications f: user management
Milestone
v0.10.0

Comments

@pronguen
Copy link
Contributor

Describe the issue
In the notifications sent (overdue, recall, availability, due_soon), the link to the patron account is not adapted to the instance deployed. It is currently always a broken link: https://ils.rero.ch/rbnj/patrons/profile

To Reproduce

  1. See notifications sent in Gmail

Expected behavior
The link should not be broken, whenever it is on ilspilot.test, ilsdev.test or ils.test

Software version
ilsdev ilspilot
rero-ils version c236bc8
rero-ils-ui version 4fc4656d
@iGormilhit iGormilhit changed the title Notification: link to patron account Link to the patron profile not adapted to the concerned instance in the notification message. Apr 21, 2020
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 7, 2020
@rerowep
notifications: patron url
db0ef6b 
* Corrects patron url. `RERO_ILS_APP_BASE_URL` is used to construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Jun 7, 2020
Merged
7 tasks
@rerowep rerowep self-assigned this Jun 7, 2020
@rerowep
Copy link
Contributor

rerowep commented Jun 7, 2020

RERO_ILS_APP_BASE_URL must be set correctly in the deployment!

rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 7, 2020
@rerowep
notifications: patron url
bbe3871 
* Corrects patron url. `RERO_ILS_APP_BASE_URL` is used to construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 8, 2020
@rerowep
notifications: patron url
838b707 
* Corrects patron url. `RERO_ILS_APP_BASE_URL` is used to construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 8, 2020
@rerowep
notifications: fix patron URL construction
6219281 
The patron profile URL in the notification messages should be adapted to the running instance.

* Corrects patron URL. `RERO_ILS_APP_BASE_URL` is used to construct the patron URL. Closes rero#802.
* Adds command line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 8, 2020
@rerowep
notifications: patron url
8943b36 
* Corrects patron url. `RERO_ILS_APP_BASE_URL` is used to construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications can now be started with `invenio run notifications process`.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 9, 2020
@rerowep
notifications: patron url
b3d9e34 
* Corrects patron url in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications
  can now be started with `invenio run notifications process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 9, 2020
@rerowep
notifications: patron url
b27fa78 
* Corrects patron url in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron url. closes rero#802
* Adds comand line interface for notifications. Process of notifications
  can now be started with `invenio run notifications process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.

Co-Authored-by: Peter Weber <[email protected]>
@iGormilhit iGormilhit added this to the v0.10.0 milestone Jun 10, 2020
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 11, 2020
@rerowep
notifications: adapt patron url to the instance
60c49d9 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes rero#802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 16, 2020
@rerowep
notifications: adapt patron url to the instance
01394d6 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes rero#802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 17, 2020
@rerowep
notifications: adapt patron url to the instance
9de1675 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes rero#802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 18, 2020
@rerowep
notifications: adapt patron url to the instance
745a296 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes rero#802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.
* Deletes `document-minimal-v0.0.1.json` schema file.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jun 18, 2020
@rerowep
notifications: adapt patron url to the instance
31968af 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes rero#802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.
* Deletes `document-minimal-v0.0.1.json` schema file.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit that referenced this issue Jun 19, 2020
@rerowep
notifications: adapt patron url to the instance
adbf9ba 
The patron URL displayed in the notifications sent to to the patron
should be automatically changed according to the deployed instance.

* Corrects patron URL in notifications. `RERO_ILS_APP_URL` is used to
  construct the patron URL. Closes #802
* Adds command line interface for notifications. Process of
  notifications can now be started with `invenio run notifications
  process`.
* Uses standart JSONSCHEMAS_ENDPOINT = '/schemas'.
* Uses JSONSCHEMAS_REPLACE_REFS = True to resolve $ref before serving a
  schema.
* Deletes all unnecessary `$schema` in fixtures.
* Deletes `document-minimal-v0.0.1.json` schema file.

Co-Authored-by: Peter Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
f: notifications f: user management
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

notifications: patron url rerowep/rero-ils
3 participants
@iGormilhit @pronguen @rerowep