Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete results not displayed, click in the input needed #788

Closed
AoNoOokami opened this issue Feb 24, 2020 · 0 comments
Closed

Autocomplete results not displayed, click in the input needed #788

AoNoOokami opened this issue Feb 24, 2020 · 0 comments
Labels
f: search
Milestone
sprint 28

Comments

@AoNoOokami
Copy link
Contributor

AoNoOokami commented Feb 24, 2020 •
edited
Loading

Describe the issue
Autocomplete: you type a search in the box but you must click in the box to see the result of autocomplete

To Reproduce
Steps to reproduce the behavior:

  1. Go to homepage
  2. Type a search in search input (no suggestions)
  3. Click in the input to see the suggestions

Expected behavior
Autocomplete results should be displayed immediately.

Software version
30830df
rero/rero-ils-ui@a183e40
@AoNoOokami AoNoOokami added the bug label Feb 24, 2020
@benerken benerken mentioned this issue Feb 24, 2020
Closed
51 tasks
@iGormilhit iGormilhit added this to the sprint 28 milestone Feb 27, 2020
@jma jma mentioned this issue Apr 27, 2020
Merged
7 tasks
jma added a commit to jma/rero-ils-ui that referenced this issue Apr 27, 2020
@jma
autocomplete: fix suggestions are not displayed
28768aa 
The list of suggestions are sometime not displayed when the server take
few milliseconds to respond. This has been fixed in a new version of the
third party library `ngx-bootstrap`.
Moreover when a document is selected the search should be executed.

* Fixes the display of the suggestion list for unquick server response.
* Executes the search query when a document title suggestion is clicked.
* Closes rero/rero-ils#788.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Apr 27, 2020
Merged
7 tasks
jma added a commit to jma/rero-ils-ui that referenced this issue Apr 27, 2020
@jma
autocomplete: fix suggestions are not displayed
fbf0724 
The list of suggestions are sometime not displayed when the server take
few milliseconds to respond. This has been fixed in a new version of the
third party library `ngx-bootstrap`.
Moreover when a document is selected the search should be executed.

* Fixes the display of the suggestion list for unquick server response.
* Executes the search query when a document title suggestion is clicked.
* Closes rero/rero-ils#788.
* Fixes minimal size value for REST API since "invenio-records-rest>1.4.2".

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils-ui that referenced this issue Apr 28, 2020
@jma
autocomplete: fix suggestions are not displayed
37c6294 
The list of suggestions are sometime not displayed when the server take
few milliseconds to respond. This has been fixed in a new version of the
third party library `ngx-bootstrap`.
Moreover when a document is selected the search should be executed.

* Fixes the display of the suggestion list for unquick server response.
* Executes the search query when a document title suggestion is clicked.
* Closes rero/rero-ils#788.
* Fixes minimal size value for REST API since "invenio-records-rest>1.4.2".
* Moves to [email protected].

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: search
Projects
None yet
Milestone
sprint 28
Development

No branches or pull requests
2 participants
@iGormilhit @AoNoOokami