Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circulation policy custom editor do not load patron types and item types settings #625

Closed
pronguen opened this issue Nov 13, 2019 · 4 comments
Closed

Circulation policy custom editor do not load patron types and item types settings #625

pronguen opened this issue Nov 13, 2019 · 4 comments
Assignees
@AoNoOokami
Labels
f: professional ui Professional interface

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 13, 2019 •
edited by iGormilhit
Loading

Describe the issue
When I save a circulation policy, the settings part is saved (check via API). But if I reopen it, the changes don't appear, even after reloading the page. What is more, I can create another policy with the same settings and save if without restriction.

To Reproduce

  1. Create a new policy
  2. Make your policy apply to specific patron and item types
  3. Save
  4. Reopen the policy
  5. See error: changes you made were not saved (ie the selection of patron and item types), even if you reload the page
  6. Create another policy applying to the same patron and item types
  7. Save it

Expected behavior

  • When reopening the policy for edition, changes are displayed without page reload.
  • It is not possible to select settings already concerned by another policy.

Software version
Tested on

  • ilsdev.test, version 1de3d25
  • ils.testversion 0.5.2
@iGormilhit iGormilhit added the f: professional ui Professional interface label Nov 14, 2019
@iGormilhit
Copy link

I cannot reproduce the issue on ilsdev. I will try again.

@iGormilhit
Copy link

I got it, it's the changes on which patron type and item types that this circulation policy is applied to, that are not displayed in the editor. The changes are commited to the database though.

@iGormilhit iGormilhit changed the title Circulation policy form/editor Circulation policy custom editor do not load patron types and item types settings Nov 21, 2019
@iGormilhit
Copy link

Should be fixed by PR #633, commit 797ee0c.

@AoNoOokami
Copy link
Contributor

Should be fixed by PR #633, commit 797ee0c.

I tried to create a circulation policy in PR #633 context, but when I click on save button, I get this error:
ERROR TypeError: settings[key].forEach is not a function

@AoNoOokami AoNoOokami mentioned this issue Nov 22, 2019
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
cf9bb07 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#625.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Nov 22, 2019
fix: correct circulation policy
169a7cb 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes rero#625.
* Closes rero#626.
* Closes rero#213.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami self-assigned this Nov 22, 2019
AoNoOokami pushed a commit that referenced this issue Nov 25, 2019
fix: correct circulation policy
5ef67e3 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami pushed a commit that referenced this issue Nov 25, 2019
fix: correct circulation policy
9299f5b 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <[email protected]>
rerowep pushed a commit that referenced this issue Nov 29, 2019
@rerowep
fix: correct circulation policy
5e06a11 
* Corrects item types and patron_types of circulation policy with pid = 10 and 11.
* Adds test to check data consistency when ci-po are created.
* Adds new patron type.
* Corrects import sorting.
* Closes #625.
* Closes #626.
* Closes #213.

Co-Authored-by: Alicia Zangger <[email protected]>
@jma jma closed this as completed in 0e71baa Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @AoNoOokami