Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Due date according to opening hours not working #599

Closed
pronguen opened this issue Nov 7, 2019 · 1 comment
Closed

Due date according to opening hours not working #599

pronguen opened this issue Nov 7, 2019 · 1 comment
Assignees
@blankoworld
Labels
f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 7, 2019

Describe the issue
The due date is not always set at an opened day.

To Reproduce

  1. Log in as Virgile
  2. Set your library "Bibliothèque du Lycée de la Vallée d'Aoste" to be opened only one day, for instance on Monday
  3. Choose an item from Bibliothèque du Lycée de la Vallée d'Aoste, with type "standard"
  4. Go to checkin for Simonetta
  5. Checkout the item for Simonetta
  6. The due date is one day after the opening day of the library

Expected behavior
The due date should be set on an opened day of the transaction library

Software version
@pronguen pronguen added the f: circulation Concerns the circulation interface or backend label Nov 7, 2019
@blankoworld blankoworld self-assigned this Nov 7, 2019
@blankoworld blankoworld mentioned this issue Jan 6, 2020
Merged
6 tasks
blankoworld added a commit to blankoworld/rero-ils that referenced this issue Jan 10, 2020
@blankoworld
loans: improve due date timezone consideration
4495b4b 
* Closes rero#599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld added a commit to blankoworld/rero-ils that referenced this issue Jan 10, 2020
@blankoworld
loans: improve due date timezone consideration
c04f993 
* Closes rero#599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld added a commit to blankoworld/rero-ils that referenced this issue Jan 10, 2020
@blankoworld
loans: improve due date timezone consideration
c6bccf0 
* Closes rero#599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld added a commit to blankoworld/rero-ils that referenced this issue Jan 10, 2020
@blankoworld
loans: improve due date timezone consideration
3d29507 
* Closes rero#599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld added a commit to blankoworld/rero-ils that referenced this issue Jan 10, 2020
@blankoworld
loans: improve due date timezone consideration
c0d0088 
* Closes rero#599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld added a commit that referenced this issue Jan 14, 2020
@blankoworld
loans: improve due date timezone consideration
01595a3 
* Closes #599 by using correct timezone for due date (it takes into
account opening hours and exception dates correctly)
* tests due date timezone
* adds get_timezone() on Library that returns BABEL_DEFAULT_TIMEZONE as default
* changes due date process to take into account Library timezone
* adds library_pid property on Loan objects

Co-Authored-by: Olivier DOSSMANN <[email protected]>
@blankoworld
Copy link
Contributor

Closed by 01595a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blankoworld blankoworld

Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blankoworld @pronguen