Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display item status on item detailed view #46

Closed
pronguen opened this issue Jun 28, 2018 · 3 comments
Closed

Display item status on item detailed view #46

pronguen opened this issue Jun 28, 2018 · 3 comments
Assignees
@BadrAly
Labels
effort: minor Solved quickly

Comments

@pronguen
Copy link
Contributor

The item status should be displayed in the item detailed view (for the librarian).
@pronguen pronguen added the effort: minor Solved quickly label Jun 28, 2018
BadrAly pushed a commit to rero/reroils-data-legacy that referenced this issue Jul 6, 2018
fix: fix rero/rero-ils#46 display item status
feb5f33 
Signed-off-by: Aly Badr <[email protected]>
@BadrAly
Copy link

BadrAly commented Jul 6, 2018

How to test:

Checkout into the branch.
(baa-#46-display-item-status)
https://github.com/rero/reroils-data/tree/baa-#46-display-item-status

Run the test.
Visit any item detailed view and make sure the item status is there

@BadrAly BadrAly self-assigned this Jul 6, 2018
BadrAly pushed a commit to rero/reroils-data-legacy that referenced this issue Jul 6, 2018
fix: fix rero/rero-ils#46 display item status
1b2e3a8 
Signed-off-by: Aly Badr <[email protected]>
BadrAly pushed a commit to rero/reroils-data-legacy that referenced this issue Jul 6, 2018
fix: fix rero/rero-ils#46 display item status
f630a92 
Signed-off-by: Aly Badr <[email protected]>
@NicolasLabat
Copy link
Contributor

Run-tests.sh to check :
lists of files in version control and sdist do not match!
missing from VCS:
reroils_data/.ropeproject
reroils_data/.ropeproject/config.py

@iGormilhit
Copy link

@NicolasLabat I think this directory is specific to your environment and that we already jumped into them before. They shouldn't be in the git index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
effort: minor Solved quickly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iGormilhit @pronguen @NicolasLabat @BadrAly