Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout for the end of a day (23h59) #417

Closed
pronguen opened this issue Jul 31, 2019 · 1 comment
Closed

Checkout for the end of a day (23h59) #417

pronguen opened this issue Jul 31, 2019 · 1 comment
Assignees
@BadrAly
Labels
f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor

Current situation:

  • we define a checkout of 3 days in the CIPO
  • We do a checkout this morning at 10:00. The system fixes the due date at today 3days = 2019-08-03 10:00

Desired situation:

  • By default, the due date is set on the end of the day (23h59)

Note for later: it will be possible to define in the circulation policy a checkout of less than one day (1 hour, 4 hours, ...)
@pronguen pronguen added the f: circulation Concerns the circulation interface or backend label Jul 31, 2019
@BadrAly
Copy link

BadrAly commented Jul 31, 2019

Same logic for the renewal transaction.

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 13, 2019
circulation: due date hours set to end of day
d698783 
* Fixes issue rero#417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly mentioned this issue Aug 13, 2019
Closed
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 13, 2019
circulation: due date hours set to end of day
2fe91b2 
* Fixes issue rero#417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 13, 2019
circulation: due date hours set to end of day
23e346b 
* Fixes issue rero#417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
Garfield-fr pushed a commit to Garfield-fr/rero-ils that referenced this issue Aug 14, 2019
@Garfield-fr
circulation: due date hours set to end of day
9d8e054 
* Fixes issue rero#417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Aug 14, 2019
Merged
BadrAly pushed a commit that referenced this issue Aug 21, 2019
circulation: due date hours set to end of day
731e236 
* Fixes issue #417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
jma pushed a commit that referenced this issue Aug 26, 2019
@jma
circulation: due date hours set to end of day
15683b2 
* Fixes issue #417
* Improves hours of due date of checkout and renewals to the end of the day.

Co-Authored-by: Aly Badr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @BadrAly