Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP2: user authentication should not base exclusively on the e-mail #2987

Closed
pronguen opened this issue Jul 5, 2022 · 0 comments · Fixed by #3064
Closed

SIP2: user authentication should not base exclusively on the e-mail #2987

pronguen opened this issue Jul 5, 2022 · 0 comments · Fixed by #3064
Assignees
@lauren-d
Labels
correction An implemented feature doesn't work as expected. f: user management p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 5, 2022

How it works

Currently, RERO ILS SIP2 authentication is used for some external platform, like Cantook (https://mediatheque-valais.cantookstation.eu/sip2_sign_in) or Pressreader.

The log in form is based on patron.barcode user.password. Based on this, the RERO ILS currently retrieves the e-mail to be able to authenticate the user via SIP2.

Ref:

rero-ils/rero_ils/modules/selfcheck/api.py

Line 84 in 6699844

def authorize_patron(barcode, password, **kwargs):

Improvement suggestion

The authentication should work also for patron without e-mail.
@pronguen pronguen added correction An implemented feature doesn't work as expected. f: user management p-High High priority (to be solved in the 2-3 next months) labels Jul 5, 2022
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 26, 2022
@lauren-d
selfcheck: fix user authentication
5dca9ca 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d self-assigned this Aug 26, 2022
@lauren-d lauren-d mentioned this issue Aug 26, 2022
Merged
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 26, 2022
@lauren-d
selfcheck: fix user authentication
2c9fd6a 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 26, 2022
@lauren-d
selfcheck: fix user authentication
c6be040 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 26, 2022
@lauren-d
selfcheck: fix user authentication
1f7c861 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 27, 2022
@lauren-d
selfcheck: fix user authentication
62dd240 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 27, 2022
@lauren-d
selfcheck: fix user authentication
f64bd6e 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 29, 2022
@lauren-d
selfcheck: fix user authentication
530f2aa 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 29, 2022
@lauren-d
selfcheck: fix user authentication
572cb38 
* Uses username or email as user login.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 29, 2022
@lauren-d
selfcheck: fix user authentication
28291a7 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 29, 2022
@lauren-d
selfcheck: fix user authentication
ab8c10d 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 29, 2022
@lauren-d
selfcheck: fix user authentication
b839f2a 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 30, 2022
@lauren-d
selfcheck: fix user authentication
b9e177c 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 31, 2022
@lauren-d
selfcheck: fix user authentication
2a6a5c7 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Aug 31, 2022
@lauren-d
selfcheck: fix user authentication
78c6a7e 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Sep 1, 2022
@lauren-d
selfcheck: fix user authentication
cb326fe 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit to lauren-d/rero-ils that referenced this issue Sep 1, 2022
@lauren-d
selfcheck: fix user authentication
99023fe 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes rero#2987.

Co-Authored-by: Lauren-D <[email protected]>
lauren-d added a commit that referenced this issue Sep 5, 2022
@lauren-d
selfcheck: fix user authentication
dd63117 
* Uses username or email as user login.
* Adds `PatronBarcodeNotFound` exception.
* Updates invenio-sip2 dependency.
* Closes #2987.

Co-Authored-by: Lauren-D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauren-d lauren-d

Labels
correction An implemented feature doesn't work as expected. f: user management p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

selfcheck: fix user authentication lauren-d/rero-ils
2 participants
@pronguen @lauren-d