Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block modification of resources linked to a non current fiscal year #2930

Closed
pronguen opened this issue May 24, 2022 · 0 comments · Fixed by #3009
Closed

Block modification of resources linked to a non current fiscal year #2930

pronguen opened this issue May 24, 2022 · 0 comments · Fixed by #3009
Assignees
@Garfield-fr @BadrAly
Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module

Comments

@pronguen
Copy link
Contributor

pronguen commented May 24, 2022 •
edited
Loading

How it works

Rollover issue

Currently, it is possible to modify resources linked to a non current fiscal year (org.current_budget). This present a big risk of error in case of various fiscal years.

Improvement suggestion

Block modification of resources linked to a non current fiscal year (field current_budget_pid OR rollover_done of the organisation).
Concerns: accounts, orders, order lines, receipts, receipt lines

TO DO

  • add a field on the budget that is managed exclusively by the system (not editable) and called rollover_done (TRUE|FALSE)
  • prevent the edition/creation of the fiscal year through the interface (managed exclusively by the system)
  • prevent the edition of the current fiscal year in the organisation
@pronguen pronguen added f: acquisitions Related to the acquisition module correction An implemented feature doesn't work as expected. labels May 24, 2022
@pronguen pronguen mentioned this issue May 24, 2022
Closed
4 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jul 22, 2022
@Garfield-fr
acquisition: block updates for resources
5821b26 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for acquisition order record.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@BadrAly BadrAly mentioned this issue Jul 22, 2022
Merged
Garfield-fr added a commit to BadrAly/rero-ils that referenced this issue Jul 26, 2022
@Garfield-fr
acquisition: block updates for resources
28fdc59 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Jul 26, 2022
@Garfield-fr
acquisition: block updates for resources
7c02cdf 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes #2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to BadrAly/rero-ils that referenced this issue Jul 27, 2022
@Garfield-fr
acquisition: block updates for resources
33ab126 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 9, 2022
@Garfield-fr
acquisition: block updates for resources
b8de078 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 9, 2022
@Garfield-fr
acquisition: block updates for resources
16b7ebf 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 9, 2022
@Garfield-fr
acquisition: block updates for resources
8ae5170 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Aug 11, 2022
@Garfield-fr
acquisition: block updates for resources
6750605 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes rero#2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Aug 11, 2022
@Garfield-fr
acquisition: block updates for resources
5543a7b 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes #2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Aug 16, 2022
@Garfield-fr
acquisition: block updates for resources
1c8455b 
The execution of the rollover process controles the setting of the
budget field is_active. Once this field is disabled, no more updates
or deletions are possible for the all resources attached to this
budget.

* Adds acquisition fixtures for a rolled over year.
* Adds serializer for all acquisition order resources.
* Adds receipts and receipt_lines fixtures.
* Fixes reasons_not_to_delete for acquisition resources.
* Closes #2930.

Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

@BadrAly BadrAly

Labels
correction An implemented feature doesn't work as expected. f: acquisitions Related to the acquisition module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acquisition: block updates for resources BadrAly/rero-ils
3 participants
@Garfield-fr @pronguen @BadrAly