Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display 20 loans instead of 10 loans in the public patron account #2750

Closed
pronguen opened this issue Mar 8, 2022 · 2 comments · Fixed by rero/rero-ils-ui#824
Closed

Display 20 loans instead of 10 loans in the public patron account #2750

pronguen opened this issue Mar 8, 2022 · 2 comments · Fixed by rero/rero-ils-ui#824
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface performance

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 8, 2022

How it works

For performance reasons, in the public patron account, only the 10 first loans are displayed. Various patrons contacted directly RERO+ to ask for displaying all the loans. They don"t understand why there is a paging.

Improvement suggestion

  • Display if possible all the loans.
  • If the performance does not allow it, display at least 20 loans (and then 20 by 20 for the hidden ones)
@pronguen pronguen added enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface performance labels Mar 8, 2022
@pronguen
Copy link
Contributor Author

pronguen commented Mar 8, 2022

@Garfield-fr Do you think performance allow to load the loans 20 by 20, or even all together? This is the case in the professional interface.

@pronguen pronguen mentioned this issue Mar 8, 2022
Closed
@Garfield-fr
Copy link
Contributor

@Garfield-fr Do you think performance allow to load the loans 20 by 20, or even all together? This is the case in the professional interface.

It is not possible to display all loans on the account due to charge on the API. However, we can go up to 20 loans to test.

@Garfield-fr Garfield-fr mentioned this issue Mar 9, 2022
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Mar 9, 2022
@Garfield-fr
patron profile: change the number of loans to 20
71a6581 
* Closes rero/rero-ils#2750.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Mar 9, 2022
@Garfield-fr
patron profile: change the number of loans to 20
b6c39b4 
* Closes rero/rero-ils#2750.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patron profile: change the number of loans to 20 Garfield-fr/rero-ils-ui
2 participants
@Garfield-fr @pronguen