Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indexes for retrieval when linkink document to another document or authority #2352

Closed
ThierryClavel opened this issue Sep 1, 2021 · 2 comments · Fixed by rero/rero-ils-ui#702
Closed

Add indexes for retrieval when linkink document to another document or authority #2352

ThierryClavel opened this issue Sep 1, 2021 · 2 comments · Fixed by rero/rero-ils-ui#702
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)

Comments

@ThierryClavel
Copy link

ThierryClavel commented Sep 1, 2021 •
edited
Loading

How it works

When cataloguing, to link a document to another document or to a MEF authority, only one index is proposed (generally Title index for documents or Access point for MEF):

Improvement suggestion

In different cases the autocompletion does not propose the right document or authority to link. as showned in example below.
image

The enhancement proposal is to add other possibilities of retrieval mainly by identifiers . For example Title ISSN ISBN for
Partof field

List of fields concerned (each with proposed indexes to add : [to be discussed by PO other indexes ? RERO ILS PID ?]
PartOf : Title / add ISSN / ISBN
PreceededBy : Title : add ISSN / ISBN
SuccededBy: Title : add ISSN / ISBN
supplement: Title : add ISSN / ISBN
supplement of : Title : add ISSN / ISBN
IssuedWith : Title : add ISSN / ISBN
AlsoIssuedas: Title : add ISSN / ISBN
Othereditions : Title : add ISSN / ISBN
Work Access Point: IDREf and GND identifiers
contributors: IDREf and GND identifiers
Subjects: IDREf and GND identifiers

An separate issue #2249 was done for display identifiers in autocompletion results
@ThierryClavel ThierryClavel added enhancement Improvement of an existing feature triage p-High High priority (to be solved in the 2-3 next months) labels Sep 1, 2021
@iGormilhit iGormilhit added f: editor Concerns editor based on JSON schema AND custom editor and removed triage labels Sep 2, 2021
@iGormilhit iGormilhit changed the title Document Editor ; link document to another document or authority : add indexes for retrieval Add indexes for retrieval when linkink document to another document or authority Sep 2, 2021
jma added a commit to jma/rero-ils-ui that referenced this issue Sep 8, 2021
@jma
editor: search everywhere for resource linking
dfe71de 
* Search everywhere when linking a document to an other document or a
  MEF authority.
* Closes rero/rero-ils#2352.
* Users ngx-formly v5.10.22.
* Fixes security issues.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Sep 8, 2021
Merged
7 tasks
@ThierryClavel
Copy link
Author

test : on ilsdev : search by ISSN in "contenu dans" field works but title is not brought back in field. When you click on blue arrow, 404 error "page not found"
image

@iGormilhit
Copy link

@ThierryClavel

test : on ilsdev : search by ISSN in "contenu dans" field works but title is not brought back in field. When you click on blue arrow, 404 error "page not found"
image

Yes, I've warned @jma about these two issues. Thanks.

jma added a commit to jma/rero-ils-ui that referenced this issue Sep 8, 2021
@jma
editor: search everywhere for resource linking
f747956 
* Search everywhere when linking a document to an other document or a
  MEF authority.
* Closes rero/rero-ils#2352.
* Uses ngx-formly v5.10.22.
* Fixes security issues.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to rero/rero-ils-ui that referenced this issue Sep 9, 2021
@jma
editor: search everywhere for resource linking
6f6dcf1 
* Search everywhere when linking a document to an other document or a
  MEF authority.
* Closes rero/rero-ils#2352.
* Uses ngx-formly v5.10.22.
* Fixes security issues.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: search everywhere for resource linking jma/rero-ils-ui
2 participants
@iGormilhit @ThierryClavel