Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a pick-up location creates bugs on the loans #2162

Closed
pronguen opened this issue Jul 14, 2021 · 2 comments
Closed

Removing a pick-up location creates bugs on the loans #2162

pronguen opened this issue Jul 14, 2021 · 2 comments
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 14, 2021 •
edited
Loading

Describe the bug

There is a location marked as pick-up. Some loans exist to pick-up from this location. If we disable the pick-up field of the locations, the circulation interface doesn't work anymore with these loans.

To Reproduce

  1. Create a request on item X to pick-up from location Y
  2. Edit location Y and remove the pick-up property
  3. Check-in item X
  4. See error

Expected behavior

  • It is possible to edit a pick-up location (enable/disable) without affecting circulation: all operations should work.

With a loan with a pick-up location that is no more "pick-up", the interface should behave as follows:

  • Pick-up name, ideally display in cascade: "[name of the library]: [location that is no more pick-up]"
    • to be corrected everywhere: in flash messages, in request list, in patron account (public/pro), in item detailed view (request queue), etc.

Context

  • server: bib.rero.ch
  • version: v1.4.1
@pronguen pronguen added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Jul 14, 2021
@iGormilhit iGormilhit added production Issue specifically spotted on the production server and removed triage labels Jul 14, 2021
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Aug 24, 2021
@pronguen pronguen mentioned this issue Aug 25, 2021
Closed
@pronguen
Copy link
Contributor Author

On 21.09, I retested this issue on v1.4.11 and it is still present. At least the following must be corrected:

  • item detailed view (request list)
  • patron account (public view)
  • enable circulation actions if the loan pick-up location is no more pick-up (currently it is not possible to validate a request)

@pronguen
Copy link
Contributor Author

Solved by #2431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months) production Issue specifically spotted on the production server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iGormilhit @pronguen