Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an item with linked fees should open a warning #2102

Closed
pronguen opened this issue Jul 1, 2021 · 0 comments · Fixed by rero/rero-ils-ui#688 or #2271
Closed

Remove an item with linked fees should open a warning #2102

pronguen opened this issue Jul 1, 2021 · 0 comments · Fixed by rero/rero-ils-ui#688 or #2271
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.5.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 1, 2021 •
edited
Loading

Describe the bug

Currently, it is possible to remove an item with linked fees.

To Reproduce

  1. Find a fee
  2. Check-in the item
  3. Delete the item
  4. See that it is possible. The fee is still displayed, but without mentioning the item (which is ok).

Expected behavior

  • There is a warning when deleting the resource, if open fees are linked to it.

Context

When the item has linked loans, it is already impossible to delete it.
Delete an item with fees does not break neither the public patron account, nor the professional patron account.
@pronguen pronguen added f: professional ui Professional interface f: permissions Concerns the rights management bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) needs info labels Jul 1, 2021
@iGormilhit iGormilhit added this to the 1.6.0 milestone Jul 6, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 5, 2021
@Garfield-fr
item: disabling delete if there is a charge
e6a67b1 
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 5, 2021
@Garfield-fr
fees: add message for delete information
1368e18 
* Closes rero/rero-ils#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
This was referenced Aug 5, 2021
Merged
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 5, 2021
@Garfield-fr
fees: add message for delete information
cd7d2b3 
* Closes rero/rero-ils#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 6, 2021
@Garfield-fr
item: disabling delete if there is a charge
98bcf45 
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 6, 2021
@Garfield-fr
item: disabling delete if there is a charge
c1bb212 
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr @zannkukai
item: disabling delete action if there is a fee
5b424fe 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr @zannkukai
item: disabling delete action if there is a fee
0d50db4 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr @zannkukai
item: disabling delete action if there is a fee
ce9174c 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 19, 2021
@Garfield-fr @zannkukai
item: disabling delete action if there is a fee
eb04d3d 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 20, 2021
@Garfield-fr @zannkukai
item: disabling delete action if there is a fee
4592115 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 20, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
a9b25cd 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
@iGormilhit iGormilhit modified the milestones: v1.6.0, v1.5.0 Aug 25, 2021
@pronguen pronguen changed the title It should not be possible to remove an item with linked fees Remove an item with linked fees should open a warning Sep 13, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 14, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
97f1b27 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 15, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
55c4159 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 15, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
d985532 
* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Sep 22, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
910c756 
Warning: the PatronTransaction data must be reindexed.

* Adds the item pid when indexing the PatronTransaction record.
* Closes rero#2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
Garfield-fr added a commit that referenced this issue Sep 23, 2021
@Garfield-fr @zannkukai
items: disable the delete action if there is a fee
ba2c911 
Warning: the PatronTransaction data must be reindexed.

* Adds the item pid when indexing the PatronTransaction record.
* Closes #2102

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Renaud Michotte <[email protected]>
@PascalRepond PascalRepond mentioned this issue May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.5.0
2 participants
@iGormilhit @pronguen