Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The system doesn't use the today's date to compute overdue fees #1954

Closed
benerken opened this issue May 27, 2021 · 0 comments · Fixed by #1955
Closed

The system doesn't use the today's date to compute overdue fees #1954

benerken opened this issue May 27, 2021 · 0 comments · Fixed by #1955
Assignees
@zannkukai
Labels
bug (critical) Blocking issue, should be fixed ASAP f: circulation Concerns the circulation interface or backend
Milestone
v1.3.0

Comments

@benerken
Copy link
Contributor

Describe the bug

The system doesn't use the current date to compute overdue fees.
it seems it uses the date when the system has been initialized.

To Reproduce

  1. Go to ils.test.rero.ch
  2. login as Astrid and go to professional view.
  3. take the patron account of Helder and check its fees. He has items in overdue.
  4. See error in the "preview overdue fees". The system computes fees from the due date until the day where the system has been started.

(seen screeshot)

Expected behavior

The system must compute fees from the due date until today.

Context

  • server: ils.test.rero.ch
  • version: v1.2.0

Screenshots

image
@benerken benerken added f: circulation Concerns the circulation interface or backend bug (critical) Blocking issue, should be fixed ASAP triage labels May 27, 2021
@benerken benerken added this to the v1.3.0 milestone May 27, 2021
@benerken benerken changed the title circulation: the system doesn't use the current date to compute overdue fees circulation: the system doesn't use the today's date to compute overdue fees May 27, 2021
@iGormilhit iGormilhit removed the triage label May 27, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 27, 2021
@zannkukai
circulation: fix fees calculation
0a6a732 
* Use `datetime.now()` as default value in function argument cause
  problem because the value is compute once, when code is compile. So
  the date keeps same value until the app is reloaded.
* Closes rero#1954.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai self-assigned this May 27, 2021
@zannkukai zannkukai mentioned this issue May 27, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 31, 2021
@zannkukai
circulation: fix fees calculation
209a541 
* Use `datetime.now()` as default value in function argument cause
  problem because the value is computed once, when code is compile. So
  the date keeps the  same value until the app is reloaded.
* Closes rero#1954.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Jun 2, 2021
@zannkukai
circulation: fix fees calculation
3ae6ad5 
* Use `datetime.now()` as default value in function argument cause
  problem because the value is computed once, when code is compile. So
  the date keeps the  same value until the app is reloaded.
* Closes #1954.

Co-Authored-by: Renaud Michotte <[email protected]>
@iGormilhit iGormilhit changed the title circulation: the system doesn't use the today's date to compute overdue fees The system doesn't use the today's date to compute overdue fees Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug (critical) Blocking issue, should be fixed ASAP f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

circulation: fix fees calculation zannkukai/rero-ils
3 participants
@iGormilhit @zannkukai @benerken