Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a holdings with items should be possible #1720

Closed
pronguen opened this issue Feb 23, 2021 · 0 comments · Fixed by #2219
Closed

Delete a holdings with items should be possible #1720

pronguen opened this issue Feb 23, 2021 · 0 comments · Fixed by #2219
Assignees
@Garfield-fr @rerowep
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.5.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Feb 23, 2021 •
edited
Loading

How it works

It is not possible to delete a holdings with items. For serials, it is neither possible to delete a holdings where all issues have the status "Deleted".

Improvement suggestion

  • It is possible to delete a holdings of type "serial".
  • This also deletes all items linked to this holdings.
  • The action is blocked if one of the item has active loan transactions.
  • A confirmation message is displayed before deleting: Do you really want to delete this record? This will also delete all items and issues of the holdings.

Side effect

  • the items of type "issue" can be deleted. This blocking is removed
  • ideally there is no distinction anymore in the data between regular/irregular issues
    • the field regular is removed
    • the button "Add irregular issue" stays as is, but it add a usual issue
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface triage p-Medium Medium priority (to be solved within 1-2 years) labels Feb 23, 2021
@iGormilhit iGormilhit removed the triage label Feb 25, 2021
@pronguen pronguen added this to the v1.4.0 milestone Jun 15, 2021
@iGormilhit iGormilhit modified the milestones: v1.4.0, v1.5.0 Jul 5, 2021
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 9, 2021
@rerowep
holdings: add delete of serials holdings
3b5a223 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 21, 2021
@rerowep
holdings: add delete of serials holdings
0ee0f00 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep mentioned this issue Jul 21, 2021
Merged
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 21, 2021
@rerowep
holdings: allow deletion of serials holdings
02d38ab 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 21, 2021
@rerowep
holdings: allow deletion of serials holdings
71e2053 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 21, 2021
@rerowep
holdings: allow deletion of serials holdings
4e28021 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 22, 2021
@rerowep
holdings: allow deletion of serials holdings
02695b4 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 22, 2021
@rerowep
holdings: allow deletion of serials holdings
ae4ba9b 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 22, 2021
@rerowep
holdings: allow deletion of serials holdings
28b7e8d 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 22, 2021
@rerowep
holdings: allow deletion of serials holdings
f2bcc12 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Jul 22, 2021
@rerowep
holdings: allow deletion of serials holdings
f871bfe 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 3, 2021
@rerowep
holdings: allow deletion of serials holdings
cf54f6f 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Aug 3, 2021
@rerowep
holdings: allow deletion of serials holdings
9acfcc1 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
jma pushed a commit to rerowep/rero-ils that referenced this issue Aug 11, 2021
@rerowep @jma
holdings: allow deletion of serials holdings
6f5e33d 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
jma pushed a commit to rerowep/rero-ils that referenced this issue Aug 11, 2021
@rerowep @jma
holdings: allow deletion of serials holdings
86315e0 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
jma pushed a commit to rerowep/rero-ils that referenced this issue Aug 11, 2021
@rerowep @jma
holdings: allow deletion of serials holdings
f4d0a02 
* Closes rero#1720.

Co-Authored-by: Peter Weber <[email protected]>
@jma jma closed this as completed in #2219 Aug 12, 2021
jma pushed a commit that referenced this issue Aug 12, 2021
@rerowep @jma
holdings: allow deletion of serials holdings
55f0798 
* Closes #1720.

Co-Authored-by: Peter Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

@rerowep rerowep

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

holdings: allow deletion of serials holdings rerowep/rero-ils
4 participants
@Garfield-fr @iGormilhit @pronguen @rerowep