Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item location and category update when parents holdings is changed. #1436

Closed
BadrAly opened this issue Nov 11, 2020 · 7 comments · Fixed by #2747
Closed

Item location and category update when parents holdings is changed. #1436

BadrAly opened this issue Nov 11, 2020 · 7 comments · Fixed by #2747
Assignees
@BadrAly
Labels
correction An implemented feature doesn't work as expected. effort: 3pt 3 point of effort estimated for the implementation f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: serials p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.10.0

Comments

@BadrAly
Copy link

BadrAly commented Nov 11, 2020 •
edited by pronguen
Loading

When I change the location or circulation category of the holdings, this same data is not changed in the item/issues. It should. Rather: the location should be removed from the issue/item.

  • version: v0.14.0
@BadrAly BadrAly added enhancement Improvement of an existing feature triage f: serials labels Nov 11, 2020
@BadrAly
Copy link
Author

BadrAly commented Nov 11, 2020 •
edited
Loading

This requires spec. For the standard holdings, when the item.location is changed, a new holding is created and the items are attached to the new holding and the old holding is deleted

@BadrAly BadrAly mentioned this issue Nov 11, 2020
Merged
6 tasks
@iGormilhit iGormilhit changed the title Item Location update when parents holdings location is changed Item location update when parents holdings location is changed. Nov 12, 2020
@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data and removed triage labels Nov 12, 2020
@iGormilhit
Copy link

@BadrAly @pronguen I have two questions:

  1. What is the priority of this issue? Low, medium, high?
  2. How the specifications will be documented? Here or in a user story?

Thanks.

@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) effort: important US candidate labels Nov 26, 2020
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Feb 1, 2021
@zannkukai zannkukai self-assigned this Feb 15, 2021
@zannkukai
Copy link
Contributor

@BadrAly I think it"s a bad idea to remove the "location" field from the item. If we remove this field from the Item resource JSON schema, the the editor will not present it for the user (create/update). It seems an huge work to dynamically add a field in the form if this one isn"t present into the schema :: complex for add the field, populate the form, save the form, ...

I suggest this solution : When an holding is updated, detect if the location field change. If it changes, then update the related items (without updating the parent holding - itself). After all items are updated, then continue the normal process of any resource update.

@pronguen pronguen added this to the v1.3.0 milestone Mar 4, 2021
@pronguen pronguen removed this from the v1.2.0 milestone Apr 14, 2021
@pronguen pronguen added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) labels May 3, 2021
@pronguen pronguen changed the title Item location update when parents holdings location is changed. Item location and category update when parents holdings is changed. Jul 11, 2021
@pronguen
Copy link
Contributor

Issue updated to include also the field "circulation category", with the same problem.

@BadrAly BadrAly assigned BadrAly and unassigned zannkukai Nov 24, 2021
@BadrAly
Copy link
Author

BadrAly commented Nov 24, 2021

Problem in production database related to this.
First action is to correct the holdings/items concerned by this bug in production.

@BadrAly
Copy link
Author

BadrAly commented Dec 1, 2021

Mass correction to fix concerned item records is done [production database]

@pronguen pronguen added this to the v1.10.0 milestone Feb 21, 2022
@pronguen pronguen removed the effort: important US candidate label Feb 22, 2022
@pronguen
Copy link
Contributor

pronguen commented Feb 22, 2022 •
edited
Loading

Grooming 22.02.22, 3 levels of solving the issue:

  1. identify if this is solved in bib.rero.ch (regular task)
  2. integrate this regular task into RERO ILS
  3. evaluate a solution of live batch corrections with alternative and efficient tools (ref. @jma)

@pronguen pronguen added the effort: 3pt 3 point of effort estimated for the implementation label Feb 22, 2022
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 4, 2022
items: update location and type after parents changes
d46c2b5 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly mentioned this issue Mar 4, 2022
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 4, 2022
items: update location and type after parents changes
ef04a39 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected. and removed enhancement Improvement of an existing feature labels Mar 4, 2022
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 4, 2022
items: update location and type after parents changes
ae859d4 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 4, 2022
items: update location and type after parents changes
e26e2cd 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 8, 2022
items: update location and type after parents changes
eef33f2 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 9, 2022
items: update location and type after parents changes
f8375a2 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 10, 2022
items: update location and type after parents changes
561dc14 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes rero#1436.

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit that referenced this issue Mar 10, 2022
items: update location and type after parents changes
18b77b0 
when updating an holding record of type serial, the system will attempt to
modify, in the background, all attached items and make sure they inherit
the new location and item_type from the parent holdings record.

* closes #1436.

Co-Authored-by: Aly Badr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
correction An implemented feature doesn't work as expected. effort: 3pt 3 point of effort estimated for the implementation f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: serials p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

items: update location and type after parents changes BadrAly/rero-ils
5 participants
@iGormilhit @pronguen @zannkukai @BadrAly @PascalRepond