Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tab displayed when opening a detailed view seems to be random. #1394

Closed
pronguen opened this issue Nov 5, 2020 · 2 comments · Fixed by #1537
Closed

The tab displayed when opening a detailed view seems to be random. #1394

pronguen opened this issue Nov 5, 2020 · 2 comments · Fixed by #1537
Assignees
@jma
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020 •
edited
Loading

How it works

In the public view, when opening a detailed view, we don't understand why a tab is opened rather than another.

Improvement suggestion

We should always land on the tab "Get".

Context

Proposed by pilot libraries
Tested on ils.test.rero.ch (v0.13.0)
@pronguen pronguen added enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface triage labels Nov 5, 2020
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 19, 2020
@iGormilhit
Copy link

I suspect that for an obscure reason, the last opened tab is stored somewhere. Maybe @Garfield-fr or @AoNoOokami have something to say.

@iGormilhit iGormilhit added this to the v1.0.0 milestone Nov 30, 2020
@AoNoOokami
Copy link
Contributor

AoNoOokami commented Dec 1, 2020 •
edited
Loading

It should be stored, but as far as tested, the javascript function that does that disturbs the display of cover thumbnail. At least, when I comment the function, the cover thumbnail is displayed. That's why I think that it's not working properly and that this issue is related to #1396

jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
530b38b 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
b4aa9a2 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Dec 3, 2020
Merged
7 tasks
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
c60c897 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
ffec4a4 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
3ef3d6f 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
6cee8b0 
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 3, 2020
@jma
assets: move to webpack
40fcec9 
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Dec 7, 2020
@jma
assets: move to webpack
68ce711 
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes rero#1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes rero#713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
@jma jma closed this as completed in #1537 Dec 7, 2020
jma added a commit that referenced this issue Dec 7, 2020
@jma
assets: move to webpack
02e514e 
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes #1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes #713.

Signed-off-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

assets: move to webpack jma/rero-ils
4 participants
@jma @iGormilhit @pronguen @AoNoOokami