Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The description of the user/patron street field should not ask for a coma. #1382

Closed
pronguen opened this issue Nov 4, 2020 · 0 comments
Closed

The description of the user/patron street field should not ask for a coma. #1382

pronguen opened this issue Nov 4, 2020 · 0 comments
Assignees
@jma
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: user management wording When text is concerned, label, message, actions…

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 4, 2020

How it works

The description of the user field street is wrong.

How it should works

Should be: "Street and number of the address" without "separated by a coma"
@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor triage labels Nov 4, 2020
@iGormilhit iGormilhit added f: user management wording When text is concerned, label, message, actions… and removed triage labels Nov 5, 2020
jma added a commit that referenced this issue Nov 5, 2020
@jma
login: add a change password API
a3ff41b 
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma self-assigned this Nov 5, 2020
jma added a commit that referenced this issue Nov 5, 2020
@jma
login: add a change password API
9cf66bd 
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 5, 2020
@jma
login: add a change password API
4689ace 
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 5, 2020
@jma
login: add a change password API
89ed394 
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 9, 2020
@jma
login: add a change password API
669962c 
* Uses patron permissions without http request.
* Adds a custom invenio-accouts change password API to allow a librarian
  to change a password for a patron.
* Makes the user_id in the patron jsonschema required.
* Gives more weight on the barcode field for the patrons searches.
* Fixes street description message in the patron JSONSchema, closes #1382.
* Fixes email validation in the patron and vendore JSONSchema, closes #1381.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Nov 9, 2020
Merged
6 tasks
@jma jma closed this as completed in 82dc440 Nov 12, 2020
@iGormilhit iGormilhit changed the title The description of the user/patron field street is wrong. The description of the user/patron street field should not ask for a coma. Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
f: editor Concerns editor based on JSON schema AND custom editor f: user management wording When text is concerned, label, message, actions…
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jma @iGormilhit @pronguen