Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serial pattern preview type error #1351

Closed
BadrAly opened this issue Nov 2, 2020 · 3 comments
Closed

serial pattern preview type error #1351

BadrAly opened this issue Nov 2, 2020 · 3 comments
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking f: serials p-Low Low priority

Comments

@BadrAly
Copy link

BadrAly commented Nov 2, 2020 •
edited
Loading

When a librarian or a system librarian pulls the holdings editor and tries to edit or create a new holdings patterns, Sentry reports this problem:

TypeError api_holding.pattern_preview
strptime() argument 1 must be str, not None

So it seems that the next_expected_date is not sent to the backend at some point:

rero_ils/modules/holdings/api.py in _increment_next_prediction at line 401
patterns.get("next_expected_date"), "%Y-%m-%d")

ref: https://sentrydev.test.rero.ch:8443/organizations/sentry/issues/8983/?query=is:unresolved

This could be related to the Taiga task: https://tree.taiga.io/project/rero21-reroils/task/1820?kanban-status=1224893 (editor sends many calls to the backend)
@BadrAly BadrAly added triage bug Breaks something but is not blocking f: serials p-Low Low priority labels Nov 2, 2020
@iGormilhit iGormilhit removed the triage label Nov 3, 2020
@iGormilhit
Copy link

iGormilhit commented Nov 3, 2020 •
edited by BadrAly
Loading

@BadrAly We need to know what is exactly this error and document it a little bit.

@iGormilhit done

@iGormilhit iGormilhit changed the title ILSPILOT: serial pattern preview type error serial pattern preview type error Nov 26, 2020
@iGormilhit
Copy link

iGormilhit commented Nov 26, 2020 •
edited
Loading

@BadrAly Is it still relevant? If not, you can close the issue, thanks.

@BadrAly BadrAly self-assigned this Nov 30, 2020
@BadrAly
Copy link
Author

BadrAly commented Nov 30, 2020

Not a problem anymore. closing

@BadrAly BadrAly closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: serials p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iGormilhit @BadrAly