Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A system librarian without role librarian doesn't have all rights and has bugs #1340

Closed
pronguen opened this issue Oct 28, 2020 · 0 comments · Fixed by #1418
Closed

A system librarian without role librarian doesn't have all rights and has bugs #1340

pronguen opened this issue Oct 28, 2020 · 0 comments · Fixed by #1418
Assignees
@jma
Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: user management p-High High priority (to be solved in the 2-3 next months)
Milestone
v0.14.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 28, 2020 •
edited
Loading

How it works

A system librarian without role librarian don't have "edit" buttons on the brief views (he should). When he edits a resource, it spins forever. When he try to do a check-out for a patron, it spins forever and never opens the check-out form.

To reproduce

  1. Open ilspilot.test.rero.ch
  2. Edit an existing user
  3. Give him the system librarian rights (but not the librarian rights)
  4. Log in as this user
  5. Try to
    • Do a checkout
    • Edit a document or another resource
    • Etc.

How it should works

A system librarian without role librarian should have all librarian rights plus others.

Context

Version: ilspilot.test.rero.ch (v0.12.0)
@pronguen pronguen added f: user management triage bug Breaks something but is not blocking labels Oct 28, 2020
@iGormilhit iGormilhit added f: permissions Concerns the rights management and removed triage labels Oct 29, 2020
@pronguen pronguen changed the title A librarian created through the interface don't have all rights and has bugs A system librarian without role librarian don't have all rights and has bugs Nov 3, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 3, 2020
@jma
permissions: fix system librarian role only
5455c81 
A system librarian should should have all the librarian rights.

* Removes the librarian role in the test fixtures for the system
  librarian martigny to test this specific case.
* Closes rero#1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Nov 3, 2020
@jma
permissions: fix system librarian role only
d036946 
A system librarian should should have all the librarian rights.

* Removes the librarian role in the test fixtures for the system
  librarian martigny to test this specific case.
* Closes rero#1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Nov 3, 2020
Merged
6 tasks
@iGormilhit iGormilhit modified the milestones: v0.15.0, v0.14.0 Nov 3, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 4, 2020
@jma
permissions: fix system librarian role only
c49008b 
A system librarian should should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes rero#1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/rero-ils that referenced this issue Nov 4, 2020
@jma
permissions: fix system librarian role only
4cc6dbf 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes rero#1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 4, 2020
@jma
permissions: fix system librarian role only
4c07d84 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@pronguen pronguen changed the title A system librarian without role librarian don't have all rights and has bugs A system librarian without role librarian doesn't have all rights and has bugs Nov 4, 2020
@pronguen pronguen added the p-High High priority (to be solved in the 2-3 next months) label Nov 4, 2020
jma added a commit that referenced this issue Nov 4, 2020
@jma
permissions: fix system librarian role only
9614866 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 5, 2020
@jma
permissions: fix system librarian role only
8b52957 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit that referenced this issue Nov 9, 2020
@jma
permissions: fix system librarian role only
1bae613 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Nov 9, 2020
Merged
6 tasks
@zannkukai zannkukai linked a pull request Nov 10, 2020 that will close this issue
patrons: manage patrons without e-mail #1418
Merged
6 tasks
@jma jma closed this as completed in #1418 Nov 12, 2020
jma added a commit that referenced this issue Nov 12, 2020
@jma
permissions: fix system librarian role only
7639de6 
A system librarian should have all the librarian rights.

* Removes the librarian role to the system librarian of Martigny in the
  test fixtures to test this specific case.
* Closes #1340.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug Breaks something but is not blocking f: permissions Concerns the rights management f: user management p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

patrons: manage patrons without e-mail rero/rero-ils
3 participants
@jma @iGormilhit @pronguen