Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The roles are not translated in the user editor. #1282

Closed
pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by rero/ng-core#304
Closed

The roles are not translated in the user editor. #1282

pronguen opened this issue Oct 12, 2020 · 0 comments · Fixed by rero/ng-core#304
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor translations Translations
Milestone
v0.14.1

Comments

@pronguen
Copy link
Contributor

Describe the bug
In the patron editor of the admin interface, the roles are not translated.

To Reproduce
Open a patron resource and edit it

Expected behavior
Should be translated

Context

  • server: ilsdev.test.rero.ch
  • version: rero-ils version 1bc8cd8, rero-ils-ui version 7291c288

Proposed by the pilot libraries

Screenshots
image
image
@pronguen pronguen added translations Translations triage bug Breaks something but is not blocking labels Oct 12, 2020
@iGormilhit iGormilhit added translations Translations and removed translations Translations triage labels Nov 3, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 3, 2020
@zannkukai zannkukai self-assigned this Nov 18, 2020
zannkukai added a commit to zannkukai/ng-core that referenced this issue Nov 19, 2020
@zannkukai
editor: fix options translation problems.
5c8b622 
In the editor, when select options are defined not as an array but as an
observable, these options are not translated. Some of the option
properties could also be lost during translation process. This commit
fixes both problems.

Closes rero/rero-ils#1282

Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Nov 19, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/ng-core that referenced this issue Nov 19, 2020
@zannkukai
editor: fix options translation problems
a874005 
Fixes two translations issues with the editor. When options for a select are defined as an
observable instead of an array, these options are not translated. Some of the option
properties could also be lost during the translation process.

Closes rero/rero-ils#1282

Authored-by: Renaud Michotte <[email protected]>
jma pushed a commit to rero/ng-core that referenced this issue Nov 19, 2020
@zannkukai @jma
editor: fix options translation problems
4a899be 
Fixes two translations issues with the editor. When options for a select are defined as an
observable instead of an array, these options are not translated. Some of the option
properties could also be lost during the translation process.

Closes rero/rero-ils#1282

Authored-by: Renaud Michotte <[email protected]>
@iGormilhit iGormilhit changed the title The roles are not translated in the patron editor. The roles are not translated in the user editor. Nov 19, 2020
@iGormilhit iGormilhit added the f: editor Concerns editor based on JSON schema AND custom editor label Nov 19, 2020
@iGormilhit iGormilhit modified the milestones: v0.15.0, v0.14.1 Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor translations Translations
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging a pull request may close this issue.

editor: fix options translation problems. zannkukai/ng-core
3 participants
@iGormilhit @pronguen @zannkukai