Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: "jump to" not always working #1035

Closed
pronguen opened this issue Jun 10, 2020 · 0 comments · Fixed by rero/ng-core#198
Closed

Editor: "jump to" not always working #1035

pronguen opened this issue Jun 10, 2020 · 0 comments · Fixed by rero/ng-core#198
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v0.11.0

Comments

@pronguen
Copy link
Contributor

Describe the issue
In the document editor, the links in the "Jump to" section are not always working. For example, with field language it doesn't work.

To Reproduce

  1. Edit an existing document
  2. In the "Jump to" section, click on "Language"

Expected behavior

  • It works for all fields
  • Ideally, it shows the 1st-level title as well (scroll level is set to low in the page, see screenshot)

Software version
https://ils.test.rero.ch/
v0.9.1

Screenshots
Capture made on ilsdev, but also valid for ils.test.
image

We should be able to see the 1st-level title, like here >
image
@pronguen pronguen added bug f: editor Concerns editor based on JSON schema AND custom editor labels Jun 10, 2020
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jun 16, 2020
@iGormilhit iGormilhit added bug Breaks something but is not blocking and removed bug labels Jun 18, 2020
zannkukai added a commit to zannkukai/ng-core that referenced this issue Jun 26, 2020
@zannkukai
editor: fix problem with jump to
4ff715a 
* Fixes invalid links for some entries from TOC/JumpTo component.

* Closes rero/rero-ils#1035

Ca-Authored-By: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Jun 26, 2020
Merged
7 tasks
@zannkukai zannkukai self-assigned this Jun 26, 2020
zannkukai added a commit to zannkukai/ng-core that referenced this issue Jun 29, 2020
@zannkukai
editor: fix problem with 'jump to' component
c0bb5d8 
Some entries from 'Jump To' components wasn't working as expected : the
focus isn't set into the first visible field of the chosen entry. This
behavior was cause by hidden fields : if the first input field for the
chosen entry is an hidden field, then the focus was set on it... This
commit solved this problem by setting the focus on the first visible
input field of the chosen 'Jump To' entry.

* Closes rero/rero-ils#1035

Ca-Authored-By: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/ng-core that referenced this issue Jul 1, 2020
@zannkukai
editor: fix problem with 'jump to' component
87e51ef 
Some entries from 'Jump To' components wasn't working as expected : the
focus isn't set into the first visible field of the chosen entry. This
behavior was cause by hidden fields : if the first input field for the
chosen entry is an hidden field, then the focus was set on it... This
commit solved this problem by setting the focus on the first visible
input field of the chosen 'Jump To' entry.

* Closes rero/rero-ils#1035

Ca-Authored-By: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

editor: fix problem with jump to zannkukai/ng-core
3 participants
@iGormilhit @pronguen @zannkukai