Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag which does not store response body #4

Closed
akshaychhajed opened this issue Sep 21, 2016 · 2 comments
Closed

Add flag which does not store response body #4

akshaychhajed opened this issue Sep 21, 2016 · 2 comments
Milestone

Comments

@akshaychhajed
Copy link

Currently, the app stores the response body in tmp.
The new flag to support quick scan to look for metrics but not interested in keeping any output around.
This would be a great feature.
It would be even better if it does all operations in memory instead of using temp files and deleting them later.

@reorx
Copy link
Owner

reorx commented Sep 21, 2016

The new flag to support quick scan to look for metrics but not interested in keeping any output around.

This is reasonable, there should be a flag to control whether to store body in file or not

It would be even better if it does all operations in memory instead of using temp files and deleting them later.

Currently impossible to achieve that, httpstat is just a wrapper for calling curl command, and since it has used -w, --write-out option, body could only be get from file that passed to -o, --output, that's why the temp file has to be created, but we can decide whether to delete it by the flag you mentioned. If you find any way to get the body without touching the file, please tell me :)

I'm considering naming the flag HTTPSTAT_SAVE_BODY, if value is true, the temp file that stores body will be kept, otherwise it will be deleted after reading.

@reorx reorx added this to the 1.2 milestone Sep 27, 2016
johnnynotsolucky pushed a commit to johnnynotsolucky/httpstat that referenced this issue Sep 27, 2016
@reorx
Copy link
Owner

reorx commented Sep 27, 2016

Implemented in the latest version.

@reorx reorx closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants