Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kedo issue1383 #1502

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Kedo issue1383 #1502

merged 5 commits into from
Dec 8, 2021

Conversation

MadFoal
Copy link
Contributor

@MadFoal MadFoal commented Dec 6, 2021

Wrote notes and tests for issue #1383

I wrote two two test cases that provide the error messages that @StaffanArvidsson references in their issue. The first way is to use the multiple flags referenced in https://picocli.info/#_repeated_options, such as

-t test case -t bad test case -t third test case

The second way is to use a comma instead of a whitespace as the delimiter.

-t test case,bad test case,third test case

…mplementation and test JUnit test cases demonstrating proper usage of multiple arguments and their type conversion error messaging.
…mplementation and test JUnit test cases demonstrating proper usage of multiple arguments and their type conversion error messaging.
@remkop remkop linked an issue Dec 6, 2021 that may be closed by this pull request
Copy link
Owner

@remkop remkop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this test class that demonstrates some of the issues discussed in #1383. I suggested some minor changes to clarify the intent of the code in some places. Can you take a look?

src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
src/test/java/picocli/MultipleArgumentsTest.java Outdated Show resolved Hide resolved
@MadFoal
Copy link
Contributor Author

MadFoal commented Dec 8, 2021

@remkop I have fixed the code based on your comments. Let us know if you need any additional changes.

@remkop remkop added this to the 4.6.3 milestone Dec 8, 2021
@remkop remkop merged commit 0dd281f into remkop:master Dec 8, 2021
@remkop
Copy link
Owner

remkop commented Dec 8, 2021

Merged. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants