Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handleError): add the ability to handle errors #15

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

kentcdodds
Copy link
Member

What:

feat(handleError): add the ability to handle errors

Why:

I describe it in the README, but basically having a build break because someone deleted a tweet is a real bummer.

How:

Added a new handleError option that will be called in the event of an error.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #15 (30823bc) into main (cc95c85) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #15    /-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           54        62     8     
  Branches        14        16     2     
=========================================
  Hits            54        62     8     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc95c85...30823bc. Read the comment docs.

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👊

@MichaelDeBoey MichaelDeBoey merged commit a6991bb into main Apr 27, 2021
@MichaelDeBoey MichaelDeBoey deleted the pr/handleError branch April 27, 2021 22:00
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants