New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gyp demands relative paths of source but doesn't enforce it #58

Open

dothebart opened this issue Oct 18, 2019 · 0 comments

dothebart commented Oct 18, 2019

to generate source file lines, gyp needs paths relative to the gypfile itself.
i.e. :

      'sources': [
        '<(V8_ROOT)/base/trace_event/common/trace_event_common.h',
        '<(V8_ROOT)/include/libplatform/libplatform-export.h',
        '<(V8_ROOT)/include/libplatform/libplatform.h',
        '<(V8_ROOT)/include/libplatform/v8-tracing.h',
        '<(V8_ROOT)/src/libplatform/default-foreground-task-runner.cc', ....
      ],

works as long as V8_ROOT is a relative path. If its absolute, the produced make file fails to trigger the compilation of these files:

OBJS := \
	$(obj).target/$(TARGET)//home/willi/src/devel/3rdParty/V8/v7.1.302.28/src/libplatform/default-foreground-task-runner.o \
	$(obj).target/$(TARGET)//home/willi/src/devel/3rdParty/V8/v7.1.302.28/src/libplatform/default-platform.o \
	$(obj).target/$(TARGET)//home/willi/src/devel/3rdParty/V8/v7.1.302.28/src/libplatform/default-worker-threads-task-runner.o \

and make will error out when trying to link these files, that it doesn't know how to create them.

either this behaviour should be fixed, or gyp should error out on absolute files

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment