-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: switch pair! from integer! to float32! #4049
base: master
Are you sure you want to change the base?
Conversation
We still need to support float pair! in the compiler lexer. |
Just curious here :) |
It is 32-bit integers in current implementation.
You have those problems too using integers. Even worse, using integers you lost precision in many places. e.g DRAW dialect, font size. |
@qtxie in the above I'm implying that the last 3 digits of the integer can be used as a fractional part. To put it another way, 1/1000 of a pixel minimum increment size. The same tactic that's used for the money datatype, really. |
@hiiamboris Ah, Ok. You mean a custom decimal format. That needs more work. Also most of the modern OSes use float32! in their Graphic APIs. Using float32! make it easier to integrated with the OS APIs. |
I see. Thanks for the info :) |
Some notes about this change:
Cons:
Using float32 pair we can work around those Cons by converting |
1ec06cd
to
7218fb4
Compare
No description provided.