hlgroups/NormalFloat/FloatBorder: Consider using the color sumiink1 instead of bg_dark #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hlgroups should use theme color names (i.e. bg), not palette colors. This was a tough decision, but I preferred floating windows to have a darker background. It arguably looks bad with common borders tho. Personally I use box characters that are drawn on the outer margin of the character grid. I'll give it a try and might reconsider tho. |
|
This can be solved using the following configs, without changing the code: vim.api.nvim_set_hl(0, "NormalFloat", { bg = "#1F1F28", blend = 0})
vim.api.nvim_set_hl(0, "FloatBorder", { bg = "#1F1F28"})
vim.api.nvim_set_hl(0, "FloatTitle", { bg = "none"})
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, LSP diagnostics, using a floating style in my case, shows a background that does not match the original background. This occurs with other apps that use floating styles such as searchbox.nvim as shown in the issue #72.
LSP diagnostic
SearchBox.nvim