Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared realms #5634

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Fix shared realms #5634

merged 6 commits into from
Mar 24, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This fixes passing objects between shared Realms.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests

@kraenhansen kraenhansen self-assigned this Mar 24, 2023
@cla-bot cla-bot bot added the cla: yes label Mar 24, 2023
takameyer
takameyer approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion :shipit:

integration-tests/tests/src/tests/shared-realms.ts Outdated Show resolved Hide resolved
@kraenhansen kraenhansen merged commit be23529 into main Mar 24, 2023
@kraenhansen kraenhansen deleted the kh/fix-shared-realms branch March 24, 2023 14:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @takameyer