Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source files from NPM package #4060

Closed
kraenhansen opened this issue Nov 2, 2021 · 2 comments
Closed

Remove source files from NPM package #4060

kraenhansen opened this issue Nov 2, 2021 · 2 comments
Labels
Breaking

Comments

@kraenhansen
Copy link
Member

kraenhansen commented Nov 2, 2021 •
edited by sync-by-unito bot
Loading

Since we're shipping prebuilt binaries for all supported platforms, there's no reason to include the src, vendor directories nor any build scripts / cmake configurations.

This was mentioned as an a-aside in a comment on another PR #3626 (comment)

I wouldn't consider this a breaking change, since all public documentation I can find instructs users to git clone our repository to build from source.
@kraenhansen kraenhansen mentioned this issue Nov 2, 2021
Closed
5 tasks
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 3, 2021

➤ Kenneth Geisshirt commented:

We have talked about removing binaries for Raspberry Pi.

@kraenhansen
Copy link
Member Author

I've pushed a fix for this to the v11 branch with 1ca72b5

@Julusian Julusian mentioned this issue Aug 30, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed unneeded files from our archive realm/realm-js
1 participant
@kraenhansen