Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenSSL dependency #7303

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Update OpenSSL dependency #7303

merged 4 commits into from
Feb 8, 2024

Conversation

fealebenpae
Copy link
Member

@fealebenpae fealebenpae commented Jan 30, 2024 •
edited
Loading

What, How & Why?

Update to OpenSSL 3.2

☑️ ToDos

  • 📝 Changelog update

@fealebenpae fealebenpae self-assigned this Jan 30, 2024
@cla-bot cla-bot bot added the cla: yes label Jan 30, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build yavor.georgiev_403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 63 unchanged lines in 14 files lost coverage.
  • Overall coverage increased ( 0.001%) to 91.841%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 82.86%
test/fuzz_tester.hpp 1 59.48%
test/test_index_string.cpp 1 94.13%
src/realm/array_backlink.cpp 2 95.9%
src/realm/array_blobs_big.cpp 2 98.72%
src/realm/query_expression.hpp 2 93.51%
src/realm/table_view.cpp 2 94.18%
test/test_lang_bind_helper.cpp 2 93.31%
src/realm/util/future.hpp 3 96.45%
src/realm/sync/transform.cpp 4 63.01%
Totals Coverage Status
Change from base Build 1998: 0.001%
Covered Lines: 235258
Relevant Lines: 256158
💛 - Coveralls

@fealebenpae fealebenpae marked this pull request as ready for review February 6, 2024 12:30
@tgoyne
Copy link
Member

tgoyne commented Feb 6, 2024

I think that REALM_USE_SYSTEM_OPENSSL_PATHS is undefined but used in non-openssl builds because the option is guarded by REALM_NEEDS_OPENSSL OR REALM_FORCE_OPENSSL but the place it's used isn't.

@fealebenpae
Copy link
Member Author

REALM_USE_SYSTEM_OPENSSL_PATHS is not always set in CMake, yes, but the #cmakedefine01 in config.h will treat the empty variable as false and evaluate to 0, but I can tweak that to make it explicit.

michael-wb
michael-wb reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
FYI - the one failure in CI (so far) was becuase yarn failed to download while setting up baas for the tests.

@fealebenpae fealebenpae merged commit d71df7c into master Feb 8, 2024
33 of 35 checks passed
@fealebenpae fealebenpae deleted the yg/openssl3.2 branch February 8, 2024 15:47
@slingshotcoupons slingshotcoupons mentioned this pull request Feb 28, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael-wb michael-wb michael-wb approved these changes

@tgoyne tgoyne tgoyne approved these changes

Assignees

@fealebenpae fealebenpae

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fealebenpae @tgoyne @michael-wb