Use a single write transaction for DiscardLocal client resets on FLX realms #7110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build github_pull_request_282770
💛 - Coveralls |
ironage
approved these changes
Nov 3, 2023
…realms Updating the subscription store in a separate write transaction from the recovery means that we temporarily commit an invalid state. If the application crashes between committing the client reset diff and updating the subscription store, the next launch of the application would try to use the now-invalid pending subscriptions that should have been discarded.
tgoyne
force-pushed
the
tg/client-reset-flx
branch
from
5c7462e
to
97523e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the subscription store in a separate write transaction from the recovery means that we temporarily commit an invalid state. If the application crashes between committing the client reset diff and updating the subscription store, the next launch of the application would try to use the now-invalid pending subscriptions that should have been discarded.
This is the fairly uninteresting case; client reset with recovery can do much more invalid things than this if the process crashes. That'll be a significantly more involved thing to fix so I'm splitting it off to a subsequent PR.