Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync client may crash after failing to download a fresh FLX realm during client reset w/recovery #6494

Closed
sync-by-unito bot opened this issue Apr 12, 2023 · 0 comments · Fixed by #6671
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 12, 2023

If a client reset occurs and client reset w/recovery or discardLocal is enabled, we'll attempt to download a fresh realm with the active subscription set of the realm being reset. Right now, if downloading that realm fails for any reason, we clear the subscription store's contents and make a new subscription set with the subscriptions we just failed to download and set the subscription set in an error state. It turns out this is wrong and will crash the sync client the next time the app starts up. The sync client needs to know the active subscription version in order to send the IDENT message the next time it starts up, that tries to read the subscription store that has no active subscription set and we crash.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant