fix snapshot_version_number when creating a mutable subscription

realm · Oct 20, 2023 · 95f10f2 · 95f10f2
1 parent aed42b1
commit 95f10f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6  8,7 @@
 * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
 * Deleting an object in an asymmetric table would cause a crash. Likely to solve [#1537](https://github.com/realm/realm-kotlin/issues/1537), since v12.1.0.
 * Fixed FLX subscriptions not being fullfilled if the session was interrupted during bootstrapping. ([PR 7042](https://github.com/realm/realm-core/pull/7042))
 * Fixed FLX subscriptions not being picked up if an upload message was sent immediately after a subscription was committed but before the sync client checks for new subscriptions via `SubscriptionStore::get_next_pending_version()`. ([PR 7042](https://github.com/realm/realm-core/pull/7042))
 
 ### Breaking changes
 * None.

diff --git a/src/realm/sync/subscriptions.cpp b/src/realm/sync/subscriptions.cpp
@@ -592,7  592,11 @@ SubscriptionSet MutableSubscriptionSet::commit()
         if (m_state == State::Uncommitted) {
             m_state = State::Pending;
         }
-        m_obj.set(mgr->m_sub_set_snapshot_version, static_cast<int64_t>(m_tr->get_version()));
 
         // m_tr->get_version() gives the read transaction number that this write is based on.
         // What we want to commit as the snapshot_version is actually the version of this commit,
         // so assuming sequential commits and we have the write lock, we use m_tr->get_version()   1.
         m_obj.set(mgr->m_sub_set_snapshot_version, static_cast<int64_t>(m_tr->get_version()   1));
 
         auto obj_sub_list = m_obj.get_linklist(mgr->m_sub_set_subscriptions);
         obj_sub_list.clear();