Post: "Builds with no index.html file"
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal changelog post announcing readthedocs/readthedocs.org#1800 Currently, we are logging this projects, but on August 1st we will be failing builds that do not generate an `index.html` on the output's directory.
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Jul 19, 2023
We announced we deprecated this in readthedocs/blog#230 and we already contacted the users to warn about this. This PR has to be merged after July 25th, 2023 and it has to be deployed on August 1st. Closes #1800
|
@humitos I thought we discussed not posting this to the blog, since it's emailing folks? |
|
I'm not opposed to communicate platform changes to our users. I think it's something good, in fact. The amount of emails we send to users it's pretty low anyways, so I'm fine keeping this pattern 👍🏼 In the future we can create different groups people can (un)subscribe as they want, but I don't think we have to solve that problem yet. |
humitos
commented
Jul 25, 2023
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Jul 26, 2023
) * Build: fail builds if there is no `index.html` in the output dir We announced we deprecated this in readthedocs/blog#230 and we already contacted the users to warn about this. This PR has to be merged after July 25th, 2023 and it has to be deployed on August 1st. Closes #1800 * Test: create an "index.html" to run build successfully --------- Co-authored-by: Eric Holscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changelog post announcing readthedocs/readthedocs.org#1800
Currently, we are logging this projects, but on August 1st we will be failing builds that do not generate an
index.htmlon the output's directory.