Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter May 2023 - ready for review #216

Merged
merged 20 commits into from
May 11, 2023
Merged

Newsletter May 2023 - ready for review #216

merged 20 commits into from
May 11, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented May 1, 2023

  • Add all roadmap items deployed
  • Security advisories
  • Upcoming changes
  • Awesome project of the month Skipped

@benjaoming benjaoming requested a review from a team as a code owner May 1, 2023 21:04
@benjaoming benjaoming marked this pull request as draft May 1, 2023 21:04
@benjaoming benjaoming removed request for a team and ericholscher May 1, 2023 21:04
@benjaoming benjaoming self-assigned this May 1, 2023
newsletter-may-2023.rst Outdated Show resolved Hide resolved
@benjaoming
Copy link
Contributor Author

I was thinking about posting a screenshot with the diff viewer in action? Would that be okay? I know it's not really operational, but it would seem nice to build some hype here? :)

@benjaoming benjaoming marked this pull request as ready for review May 3, 2023 12:17
newsletter-may-2023.rst Outdated Show resolved Hide resolved
@benjaoming
Copy link
Contributor Author

benjaoming commented May 3, 2023

@ericholscher the newsletter got a bit tricky in the end, lacking the perfect screenshot to make it feel finished :)

But I'm pretty happy with the set of textual updates here. If you can add your touch of language magic, I think we could ship this? We have a pretty hard couple of weeks ahead, so I don't find it very realistic to seek out more content here :|

@benjaoming benjaoming changed the title Newsletter May 2023 - open for ideas Newsletter May 2023 - ready for review May 4, 2023
newsletter-may-2023.rst Outdated Show resolved Hide resolved
newsletter-may-2023.rst Outdated Show resolved Hide resolved
newsletter-may-2023.rst Outdated Show resolved Hide resolved
newsletter-may-2023.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of @stsewd's proposals, I just added a few comments.

newsletter-may-2023.rst Outdated Show resolved Hide resolved
newsletter-may-2023.rst Outdated Show resolved Hide resolved
newsletter-may-2023.rst Outdated Show resolved Hide resolved
@benjaoming
Copy link
Contributor Author

Just returning to my previous comment here:

the newsletter got a bit tricky in the end, lacking the perfect screenshot to make it feel finished :)

But I'm pretty happy with the set of textual updates here.

Since the most stunning textual upgrade about the readthedocs-client was removed, I decided to go with a screenshot of the new 404 pages - since that was pretty easy to do.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

newsletter-may-2023.rst Outdated Show resolved Hide resolved
@benjaoming benjaoming merged commit 600e46f into main May 11, 2023
@benjaoming benjaoming deleted the newsletter-may-2023 branch May 11, 2023 21:10
@benjaoming
Copy link
Contributor Author

Thanks for all the input! I'm not sure if the newsletter is sent to the mailing list on Fridays, but it's ready now 👍

@benjaoming
Copy link
Contributor Author

Correcting myself.. it will go out to the mailing list on Fridays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants