Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHELL32] IDD_BROWSE_FOR_FOLDER: Use IDOK for 1, IDCANCEL for 2 #6937

Merged
merged 1 commit into from
May 25, 2024
Merged

[SHELL32] IDD_BROWSE_FOR_FOLDER: Use IDOK for 1, IDCANCEL for 2 #6937

merged 1 commit into from
May 25, 2024

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented May 25, 2024 •
edited
Loading

Purpose

Follow-up to #6934. Don't use magic numbers.

JIRA issue: N/A

Proposed changes

  • Use IDOK and IDCANCEL instead of 1 and 2.

TODO

  • Do check.

@katahiromz katahiromz added refactoring For refactoring changes. shell All PR's related to the shell (and shell extensions) labels May 25, 2024
@katahiromz katahiromz merged commit 70e8653 into reactos:master May 25, 2024
34 checks passed
@katahiromz katahiromz deleted the ok-cancel branch May 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@learn-more learn-more Awaiting requested review from learn-more learn-more is a code owner

@yagoulas yagoulas Awaiting requested review from yagoulas yagoulas is a code owner

Assignees
No one assigned
Labels
refactoring For refactoring changes. shell All PR's related to the shell (and shell extensions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@katahiromz