[SHELL32_APITEST] Stricter SHSimpleIDListFromPath tests #6894
Conversation
The first x number of bytes in PIDLs for drive letters, folders and files are set in stone and should match Windows.
| return pidl && pidl->mkid.cb >= 3 ? (pidl->mkid.abID[0] & 0x7F) : 0; | ||
| } | ||
|
|
||
| struct FS95 |
There was a problem hiding this comment.
A doxygen comment block to document what this is about would be welcome.
There was a problem hiding this comment.
GetPIDLType...returns the type of pidl. PIDLTYPE type; in pidl.h but several of the PT_ values there are incorrect and have horrible names.
| } | ||
|
|
||
| #define TEST_CLSID(pidl, type, offset, clsid) \ | ||
| do { \ |
There was a problem hiding this comment.
you could remove one indentation level in this definition (here the do { serves a similar functionality as the opening { of a function)
There was a problem hiding this comment.
That would put the do on the same indent as the #define, that does not sound right?
There was a problem hiding this comment.
Do as you wish (my suggestion would look like this: )
reactos/dll/cpl/console/layout.c
Lines 122 to 128 in 6d7648d
|
Can we have a before and after picture of the suite running (fine)? |
Running where? It passes everything on Windows, the control panel PIDL fails on ROS. |
The first x number of bytes in PIDLs for drive letters, folders and files are set in stone and should match Windows.
This is a follow-up to PR #6892 and tests binary compatibility instead of checking that what we (incorrectly) generate smells correct when we ask our own functions to give us information about the PIDL.