-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Change Newtonsoft.Json to System.Text.Json #3562
Conversation
Needs tests added
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3562 /- ##
==========================================
Coverage 58.62% 59.24% 0.62%
==========================================
Files 158 158
Lines 5829 5899 70
Branches 1030 1030
==========================================
Hits 3417 3495 78
Misses 2029 2021 -8
Partials 383 383
☔ View full report in Codecov by Sentry. |
Need to check that there is sufficient tests to cover this change
This is a Mega Double Plus breaking change because if you're using serialization, you could end up switching serialization frameworks across an upgrade |
Yes this will be a Version update |
Yeah going to be a major version bump and some nice big disclaimers. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Feature #3190
What is the current behaviour?
No support for System.Text.Json
What is the new behaviour?
System.Text.Json support for Serialization added
https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-7-0
What might this PR break?
If other Serializers are used verification of correct serialisation should be confirmed
Please check if the PR fulfills these requirements
Other information: