Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Change Newtonsoft.Json to System.Text.Json #3562

Merged
merged 7 commits into from
Nov 18, 2023

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Jun 23, 2023

What kind of change does this PR introduce?

Feature #3190

What is the current behaviour?

No support for System.Text.Json

What is the new behaviour?

System.Text.Json support for Serialization added
https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-7-0

What might this PR break?

If other Serializers are used verification of correct serialisation should be confirmed

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2b677ca) 58.62% compared to head (eaadb80) 59.24%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3562       /-   ##
==========================================
  Coverage   58.62%   59.24%    0.62%     
==========================================
  Files         158      158              
  Lines        5829     5899       70     
  Branches     1030     1030              
==========================================
  Hits         3417     3495       78     
  Misses       2029     2021       -8     
  Partials      383      383              
Files Coverage Δ
src/ReactiveUI/Comparers/ChainedComparer.cs 86.66% <ø> (-0.84%) ⬇️
src/ReactiveUI/Comparers/OrderedComparer.cs 63.63% <ø> (ø)
src/ReactiveUI/Interactions/Interaction.cs 99.03% <100.00%> ( 1.26%) ⬆️
...veUI/Interactions/UnhandledInteractionException.cs 89.47% <ø> ( 47.36%) ⬆️
src/ReactiveUI/Mixins/AutoPersistHelper.cs 82.03% <ø> (ø)
...ObservableForProperty/INPCObservableForProperty.cs 70.27% <ø> (ø)
src/ReactiveUI/ReactiveObject/ReactiveObject.cs 94.28% <ø> ( 5.71%) ⬆️
src/ReactiveUI/ReactiveObject/ReactiveRecord.cs 0.00% <ø> (ø)
src/ReactiveUI/Routing/NotAWeakReference.cs 100.00% <ø> (ø)
src/ReactiveUI/Routing/RoutingState.cs 97.67% <100.00%> ( 4.65%) ⬆️
... and 9 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman marked this pull request as draft July 3, 2023 00:07
@ChrisPulman ChrisPulman changed the title Feature : Add System.Text.Json Feature : Change Newtonsoft.Json to System.Text.Json Nov 5, 2023
@ChrisPulman ChrisPulman marked this pull request as ready for review November 5, 2023 21:51
@anaisbetts
Copy link
Member

This is a Mega Double Plus breaking change because if you're using serialization, you could end up switching serialization frameworks across an upgrade

@ChrisPulman
Copy link
Member Author

This is a Mega Double Plus breaking change because if you're using serialization, you could end up switching serialization frameworks across an upgrade

Yes this will be a Version update

@glennawatson
Copy link
Contributor

Yeah going to be a major version bump and some nice big disclaimers.

@glennawatson glennawatson merged commit c643a4a into main Nov 18, 2023
2 of 3 checks passed
@glennawatson glennawatson deleted the CP_AddSystemTextJson branch November 18, 2023 00:21
Copy link

github-actions bot commented Dec 3, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants