Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components missing testID prop #3786

Open
1 task done
KrisLau opened this issue May 10, 2023 · 4 comments · Fixed by #3787
Open
1 task done

Components missing testID prop #3786

KrisLau opened this issue May 10, 2023 · 4 comments · Fixed by #3787
Labels
Good First Issue Good to take Testing

Comments

@KrisLau
Copy link
Contributor

KrisLau commented May 10, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Explain what you did

Adding maestro tests and noticed Icon,ListItem.Swipeable, & SpeedDial.Action missing testID prop. Also cannot pass it as an icon prop

EDIT: Found more. I believe that the list in #1966 is still relevant and correct.

Expected behavior

allows adding testID to the SpeedDial.Action, ListItem.Swipeable, or the icon props

Describe the bug

testID doesn't get passed to the component

Steps To Reproduce

Pass testID to the `SpeedDial.Action`
Try to get maestro to touch the element using the testID
test will fail

Screenshots

No response

Your Environment

`npx @rneui/envinfo` 
  ```
    Output from `npx @rneui/envinfo` goes here.
  ```
@KrisLau KrisLau changed the title SpeedDial.Action missing testID prop Icon & SpeedDial.Action missing testID prop May 11, 2023
This was referenced May 11, 2023
Closed
Merged
@KrisLau KrisLau changed the title Icon & SpeedDial.Action missing testID prop Components missing testID prop May 11, 2023
@KrisLau
Copy link
Contributor Author

KrisLau commented Jun 7, 2023

@arpitBhalla Should not be closed yet ListItem.Swipeable, & SpeedDial.Action are still missing testID prop

@arpitBhalla
Copy link
Member

Was linked to that PR, closed automatically.

@arpitBhalla arpitBhalla reopened this Jun 7, 2023
@SRVikash
Copy link

Can i work on this ??

@swarajmhatre
Copy link

Can you please assign me this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good to take Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Icon): add testID prop
4 participants
@KrisLau @arpitBhalla @SRVikash @swarajmhatre