Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Suggestion) Would consider add 'Overriding Default Elements' feature. #139

Closed
CrisLi opened this issue May 12, 2017 · 3 comments
Closed

(Suggestion) Would consider add 'Overriding Default Elements' feature. #139

CrisLi opened this issue May 12, 2017 · 3 comments
Assignees
@yesmeck
Labels
Feature

Comments

@CrisLi
Copy link

CrisLi commented May 12, 2017

I am comparing rc-table and reactabular.

One of good feature of reactabular is that it can Overriding Default Elements.

Would we consider add a similar feature. Then our table can apply any css framework or existing react component, such as react.semantic-ui.com and react-bootstrap.github.io
@paranoidjk
Copy link
Member

I think props.render can be used to custom elemts, see https://github.com/react-component/table#column-props

@CrisLi
Copy link
Author

CrisLi commented May 15, 2017

@paranoidjk props.render only can custom the element inside the td (column).

The reactabular has better custom options.

{
  components: {
    table: 'table',
    header: {
      wrapper: 'thead',
      row: 'tr',
      cell: 'th'
    },
    body: {
      wrapper: 'tbody',
      row: 'tr',
      cell: 'td'
    }
  }
};

@paranoidjk
Copy link
Member

well, i see. But this feature seems not very high priority to us， so welcome PR.

https://github.com/react-component/table/blob/master/src/TableCell.jsx#L73
https://github.com/react-component/table/blob/master/src/TableHeader.jsx#L19

@yesmeck yesmeck mentioned this issue Aug 8, 2017
Closed
@yesmeck yesmeck self-assigned this Oct 23, 2017
@yesmeck yesmeck mentioned this issue Oct 25, 2017
Merged
@yesmeck yesmeck closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yesmeck yesmeck

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CrisLi @yesmeck @paranoidjk