Add type validation for ray.autoscaler.sdk.request_resources() #26626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Your Name <[email protected]>
|
@DmitriGekhtman Thank you for approving the other PR. I messed up the rebase. Can you please take a look on this PR instead when you get a chance ? I have addressed all comments and DCO. |
Signed-off-by: Your Name <[email protected]>
DmitriGekhtman
approved these changes
Jul 16, 2022
DmitriGekhtman
changed the title
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: Xiaowei Jiang <[email protected]>
avnishn
pushed a commit
to smorad/ray
that referenced
this pull request
Jul 20, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: Avnish <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: klwuibm <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: Frank Luan <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources().
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…oject#26626) Adds type validation to ray.autoscaler.sdk.request_resources(). Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
#23166 needed type validation in autoscaler for bundles.
Related issue number
Closes #23166
Checks
scripts/format.shto lint the changes in this PR.